Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_schenker #841

Open
wants to merge 26 commits into
base: 17.0
Choose a base branch
from

Conversation

pablo-marin-s73
Copy link

@pablo-marin-s73 pablo-marin-s73 commented Jun 26, 2024

Standard Migration 17.0

Depends on:

@pablo-marin-s73 pablo-marin-s73 force-pushed the 17.0-mig-delivery_schenker branch from be86436 to 3fbd6bd Compare July 2, 2024 13:21
Copy link
Member

@hildickethan hildickethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional

chienandalu and others added 26 commits July 23, 2024 17:14
If we had a non-zero value that ended up being < 0.01, it would send 0.0 and fail
When returning an error, any call to rate_shipment will completely block the transaction
which is undesirable as it is always called when making an order through a website and the end customer gets an error.
The expected/correct way of handling this is to return a dict with an appropriate warning
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_schenker
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_schenker
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker/
@sbiosca-s73 sbiosca-s73 force-pushed the 17.0-mig-delivery_schenker branch from 3fbd6bd to 0abcf08 Compare July 23, 2024 15:16
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants