Fixed Negative Contract Base Pay #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the calculation of payment multipliers by factoring in operations tempo, reputation, employer type, required combat teams, and difficulty disparities. Enhanced the contract difficulty method to provide clearer documentation and applied clamping for normalized results. These changes aim to ensure more balanced and transparent contract evaluations.
Extracted unofficial multiplier logic into a dedicated method for clarity and reusability. Simplified the main calculation by removing duplicate logic and centralizing modifications in `getUnofficialMultiplier`. This improves code readability and maintainability.
Simplified logic by gating difficulty-based pay modification under the useGenericBattleValue option. This ensures the adjustment is only applied when relevant and avoids unnecessary calculations otherwise.
IllianiCBT
added
Bug
Major
Replaced invalid `<h3>` tag with `<b>` to ensure proper HTML compliance within Javadoc comments. This change improves documentation readability and adheres to standard HTML practices.
Corrected HTML tags in the documentation comments for clarity and adherence to standards. Ensured proper closing of <p> tags to maintain consistency in the codebase.
Adjusted HTML tag structure in method documentation for better readability and formatting consistency. Removed redundant closing tags and improved explanation layout.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5900 +/- ##
============================================
- Coverage 10.30% 10.29% -0.01%
+ Complexity 6129 6123 -6
============================================
Files 1038 1038
Lines 139154 139161 +7
Branches 20609 20610 +1
============================================
- Hits 14335 14329 -6
- Misses 123424 123434 +10
- Partials 1395 1398 +3 ☔ View full report in Codecov by Sentry. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculateContractDifficultyso developers are aware it can, on occasion, return a value outside of the expected 1-10 bounds. Fix [Issue] Negative contract pay #5898These changes ensure required lances and difficulty (if FG3 is enabled) properly impact contract pay.