Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Arc Editor #4020

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Fix conflicts

e579c30
Select commit
Loading
Failed to load commit list.
Draft

Story Arc Editor #4020

Fix conflicts
e579c30
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded May 28, 2024 in 4s

2 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 408 in MekHQ/src/mekhq/gui/dialog/DataLoadingDialog.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
storyArcStub
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 67 in MekHQ/src/mekhq/campaign/storyarc/storypoint/RollDiceStoryPoint.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
StoryPoint.getAllPossibleResults
Loading
; it is advisable to add an Override annotation.