Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Arc Editor #4020

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

AaronGullickson
Copy link
Member

No description provided.

@AaronGullickson AaronGullickson self-assigned this Apr 22, 2024
@AaronGullickson AaronGullickson added GUI Story Arcs - RFE This is specific for RFE's related to Story Arc functionality. labels Apr 22, 2024
@AaronGullickson AaronGullickson linked an issue Apr 22, 2024 that may be closed by this pull request
@@ -396,9 +404,13 @@
if (campaign != null) {
getApplication().setCampaign(campaign);
getApplication().getCampaignController().setHost(campaign.getId());
getApplication().showNewView();
if(storyArcEditor) {
getApplication().showNewStoryArcEditor(storyArcStub.loadStoryArc(campaign));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
storyArcStub
may be null at this access as suggested by
this
null guard.
@@ -60,6 +63,16 @@
return Integer.toString(value);
}

public List<String> getAllPossibleResults() {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
StoryPoint.getAllPossibleResults
; it is advisable to add an Override annotation.
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.07%. Comparing base (fc1deac) to head (4185450).
Report is 251 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4020      +/-   ##
============================================
+ Coverage     10.32%   11.07%   +0.75%     
- Complexity     6094     6435     +341     
============================================
  Files          1032     1076      +44     
  Lines        138661   141335    +2674     
  Branches      20553    20949     +396     
============================================
+ Hits          14315    15659    +1344     
- Misses       122905   124058    +1153     
- Partials       1441     1618     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS added the Draft Work in Progress label Jan 31, 2025
Comment on lines +173 to +174
MegaMekButton btnStoryArcEditor = new MegaMekButton(resources.getString("btnStoryArcEditor.text"),
UIComponents.MainMenuButton.getComp(), true);

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'MegaMekButton btnStoryArcEditor' is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Work in Progress GUI Story Arcs - RFE This is specific for RFE's related to Story Arc functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Story Arc Editor
3 participants