Conversation
Explorer finding: a control is too small to tap reliably The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: accessibility Found on revision: 59ef790 Repro: 1. set this state first: account `e2e-empty-1789812454@example.com` (the failed `fresh` sign-in), $10 credits, 3 Code Reviewer PRs, a second organization (42852247-0bc9-4794-ac17-0dfb7cd15c30), one top-level `permission` session (ses_f46c67376ffeaXQv13Fi1wpxCg), no GitHub/GitLab linked, no repos; device landscape 2400x1080, system day mode, default density.; the device in light mode 2. open the app on emulator-5554 3. reach the screen the capture names (the screen the capture names) 4. the capture shows the defect named below Observed: controls below 28dp on a side: agents-list: 1 small control(s): Filter sessions (54x54px) Expected: every control is at least 28dp on a side Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-ede15598/agents-empty.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-ede15598/agents-list.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-ede15598/agents-search-empty.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-ede15598/code-reviewer-empty.png Production record (automatic, 2026-09-19): ## Production record for `ses_f46c67376ffeaXQv13Fi1wpxCg` ### Ax
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe Filter sessions button now owns a fixed 44×44 Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
bot: Rejected, no code change (kwf Why: (already implemented, verified live: no change needed: The alleged platform fork is a test-only type import; the production Filter sessions button already uses one shared 44×44 implementation for iOS and Android. The finding is unsupported: apps/mobile/src/components/agents/session-filter-button.mounted.test.tsx:5 imports only compiler |
|
Closing as a duplicate of #6395. This PR and ten others came from the same explorer finding, #6395 is kept because it is the broadest of the group (14 files of the 34 the group touches). Any screen still below the tap-target bar after #6395 merges will be found again by the same scan, and will now arrive as one finding: the intake refuses a finding whose slug already has an open PR or a live section (kwf 07c842fd). |
Changelog for users
Changelog for maintainers
session-filter-button.tsxnow reserves a fixedh-[44px] w-[44px] shrink-0layout box on thePressable; the previoushitSlopwas clipped to the parent and never enlarged the measured target.hitSlop; the target no longer depends on the header gap or trailing margin.View, so the badge stays anchored to the icon's top-right while the outerPressableowns the full target.session-filter-button.mounted.test.tsxasserts the 44dp classes, native-compiled 44-unit width/height withflexShrink: 0, and unchanged label, badge, and press behavior for active counts 0, 1, and 12.session-filter-button.tsx, then confirm the badge corner anchoring and that adjacent header controls stay independently tappable.e2-applied2.log,e2-cleared.log,e2-nomatch.log,e2-clearfilters.log) replaces the follow-up that called that scenario unproven.E2E proof
Owner request
E2E proof — log excerpts