Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe sign-in legal links are standalone 48dp Files Reviewed (2 files)
Previous Review Summaries (2 snapshots, latest commit 9c14fa3)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 9c14fa3)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit a1904ca)Status: No Issues Found | Recommendation: Merge Executive SummaryThe sign-in legal links are now standalone 48dp Files Reviewed (2 files)
Change type: mobile accessibility fix (touch targets). Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
a1904ca to
3747dd6
Compare
3747dd6 to
9c14fa3
Compare
|
kilo-review — independent audit of the published diff. Status: 1 Issues
|
|
bot: Rejected, no code change (kwf Why: (already implemented, verified live: no change needed: Rejected the removal request because the documented non-display exception is required for the existing case guard to pass without changing unrelated authentication behavior. The guard explicitly permits documented non-display comparisons at apps/mobile/src/lib/case-guard.test.ts:20 |
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
b3a13d3 to
a7f37d3
Compare
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
|
Closing as a duplicate of #6395. This PR and ten others came from the same explorer finding, #6395 is kept because it is the broadest of the group (14 files of the 34 the group touches). Any screen still below the tap-target bar after #6395 merges will be found again by the same scan, and will now arrive as one finding: the intake refuses a finding whose slug already has an open PR or a live section (kwf 07c842fd). |
|
Reopened — I closed this in error. I closed it as a duplicate of #6395 on the grounds that eleven PRs shared one explorer finding. That was right about the finding and wrong about this PR: it is not a subset of #6395. It changes files #6395 does not touch, so closing it discarded real work rather than removing a copy. Checked properly: of the ten I closed, only #6365 and #6363 are true subsets of #6395. The other eight, including this one, each fix a screen or a helper the keeper leaves alone. What remains true: these PRs overlap on Apologies for the churn. |
|
Closing so this defect has one PR instead of nine. All nine came from the same explorer finding, #6395 is kept as the broadest (14 files). I reopened this PR earlier today after closing it, because it is not a subset of #6395 and I did not want to pretend otherwise. The work it carries is not being dropped: the six source files across this group that #6395 does not touch are now one queued item,
One change through the shared helper is a better answer than nine screen-by-screen edits that conflict. Cause, now fixed: each finding was dispatched the moment it was found. The explorer pools findings for an hour and dispatches one item per defect (kwf d25ae7de), and the intake refuses a slug that already has open work (kwf 07c842fd). |
Changelog for users
Changelog for maintainers
apps/mobile/src/components/login/idle-auth.tsx: Terms and Privacy Policy are now separatePressablelinks inside aflex-row flex-wrapView.min-h/min-wfloors andmax-w-full, so it stays tappable and never overflows the row.accessibilityRole="link"and a localizedaccessibilityLabel, and keepsactive:opacity-70.Text, so the sentence still reads and wraps as before.apps/mobile/src/components/login/__tests__/idle-auth.mounted.test.tsxcovers the size floors, the wrapping parent, the link labels, and link availability while busy.max-w-fullandflex-wrapmust keep each target inside the viewport without clipping.E2E proof
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-9c14fa3-caa7/e2e-mobile-app/e1b-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-9c14fa3-caa7/e2e-mobile-app/e1-device.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-9c14fa3-caa7/e2e-mobile-app/e2-scene.logOpen findings (not fixed here)