Conversation
Explorer finding: a control is too small to tap reliably The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: accessibility Found on revision: fd04ca1 Repro: 1. open the app on emulator-5554 2. reach the screen the capture names (the screen the capture names) 3. the capture shows the defect named below Observed: controls below 28dp on a side: agents: 1 small control(s): Filter sessions (52x52px) org-manage: 1 small control(s): Rename organization (42x42px) org-members: 1 small control(s): Invite member (57x57px) profile-org: 1 small control(s): Rename organization (42x42px) Expected: every control is at least 28dp on a side Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/agents.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home-ar.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home-dark.png - ~/.local/share/kwf/findings/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4/home.png
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the new shared Files Reviewed (10 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
|
Closing as a duplicate of #6395. This PR and ten others came from the same explorer finding, #6395 is kept because it is the broadest of the group (14 files of the 34 the group touches). Any screen still below the tap-target bar after #6395 merges will be found again by the same scan, and will now arrive as one finding: the intake refuses a finding whose slug already has an open PR or a live section (kwf 07c842fd). |
|
Reopened — I closed this in error. I closed it as a duplicate of #6395 on the grounds that eleven PRs shared one explorer finding. That was right about the finding and wrong about this PR: it is not a subset of #6395. It changes files #6395 does not touch, so closing it discarded real work rather than removing a copy. Checked properly: of the ten I closed, only #6365 and #6363 are true subsets of #6395. The other eight, including this one, each fix a screen or a helper the keeper leaves alone. What remains true: these PRs overlap on Apologies for the churn. |
|
Closing so this defect has one PR instead of nine. All nine came from the same explorer finding, #6395 is kept as the broadest (14 files). I reopened this PR earlier today after closing it, because it is not a subset of #6395 and I did not want to pretend otherwise. The work it carries is not being dropped: the six source files across this group that #6395 does not touch are now one queued item,
One change through the shared helper is a better answer than nine screen-by-screen edits that conflict. Cause, now fixed: each finding was dispatched the moment it was found. The explorer pools findings for an hour and dispatches one item per defect (kwf d25ae7de), and the intake refuses a slug that already has open work (kwf 07c842fd). |
Changelog for users
Changelog for maintainers
IconButtonrenders icon-only controls in a 32×32pt box with 8pthitSlop, giving a 48pt effective target over the 28dp accessibility minimum and the 44pt DESIGN.md minimum.SessionFilterButton, the organization hub rename pencil, and the members Invite member control now render throughIconButton, with the icon centered in a 20pt inner box.apps/mobile/src/components/ui/icon-button.tsxfirst: confirm callerclassNamemerges after the default box and that any callerhitSlopoverride stays adequate.E2E proof
[e2] Profile -> Organization: tap the pencil 'Rename organization' beside the organization name -> the rename sheet opens and saving a new name updates the row. — android (emulator-5604). One scripted scene from the personal Profile switched to the org ([seed:w4c-org-pair] e2e-org-owner-...), opened Manage organization, tapped the pencil, typed into 'Enter organization name' and tapped Save; e2-scene.log line 1 is 'SCENE e2 OK' and its post-save digest shows the hub header row 'android.view.View e2e-org-renamed tappable [111,167][1044,232]' where the seeded name was before (the DB row cd41b3f7-... became 'e2e-org-renamed', then I restored the 107-char seeded name in e2-restore.log so other shards are unaffected). Screenshot e2.png captured for the…
[e5] Re-run the explorer's control-size scan on Agents, Organization (both entries) and Organization Members: no control under 28dp on a side is reported (previously Filter sessions 52x52px, Rename… — android (emulator-5604, density 2.625 -> 28dp = 73.5px). Scan of the four screens' a11y hierarchies (e5-agents.xml, e5-org-index.xml, e5-org-deeplink.xml, e5-org-members.xml) reports 'Filter sessions <-- scanned control 28dp-OK', 'Rename organization <-- scanned control 28dp-OK' (hub via profile entry and via the organization/ deep link) and 'Invite member <-- scanned control 28dp-OK', all measured 84x84px = 32.0x32.0dp, up from 52/42/57px; no icon control under 28dp. Screenshots e5-agents.png, e5-org-index.png, e5-org-deeplink.png, e5-org-members.png captured for the visual reviewer (not…
[e5] Re-run the explorer's control-size scan on Agents, Organization (both entries) and Organization Members: no control under 28dp on a side is reported (previously Filter sessions 52x52px, Rename…
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-script.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-hub.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1b-manage-hub.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-a-control-is-too-small-to-tap-reliably-6790f7d4-3a6c/e2e-mobile-app/e1-members.logOwner request
Follow-ups (not changed here)
Open findings (not fixed here)