Add 3D advection-diffusion #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All seems to be working except the test for a time varying flow in 3D fails. Not sure why yet.
Had a wrong variable in `calc_N!`. Fixed now all tests pass. Need to do some beautifications so that indenting is the same.
Code alignment and further homogenise docstrings.
|
@jbisits I thought we change the diffusivities so that κ is x. It's a bit more intuitive now that we have 1D, 2D, 3D. |
|
|
navidcy
approved these changes
Jul 2, 2022
|
I don't think an example is needed. |
|
OK, fixed the tests! I had broken the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to advect-diffuse a passive tracer in a 3D domain. It adds a new method to
TracerAdvectionDiffusion.Problemthat takes in a flow of typeThreeDAdvectingFlow. The setup of theProblemis the same as for the one and two dimensional methods already there.I have written some tests but have not written an example. With the setup and simulation being so similar to the 1D and 2D cases do you think it necessary to have an example for the 3D advection-diffusion? Happy to write one just thought would see what you thought first.
I also have not updated any documentation files yet (e.g. the manual) but can do so if you think everything looks to be performing ok.