Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize TracerAdvDiff module to 1D and 3D #8

Closed
navidcy opened this issue Jan 25, 2020 · 5 comments · Fixed by #57
Closed

Generalize TracerAdvDiff module to 1D and 3D #8

navidcy opened this issue Jan 25, 2020 · 5 comments · Fixed by #57
Assignees
@navidcy
Labels
enhancement New feature or request

Comments

@navidcy
Copy link
Member

navidcy commented Jan 25, 2020

TracerAdvDiff should work seemlessly for 1D and 3D domains also.
@navidcy navidcy added the enhancement New feature or request label Jan 25, 2020
@navidcy navidcy self-assigned this Jan 25, 2020
@jbisits
Copy link
Collaborator

jbisits commented Jun 8, 2022

I am keen to have a look at these though not sure exactly when I will have time. Do you think it best if they are in the TracerAdvectionDiffusion module or should they be implemented in seperate modules e.g. TracerAdvectionDiffusion1D?

@navidcy
Copy link
Member Author

navidcy commented Jun 8, 2022

Either way. But within the same module should work. We can use multiple dispatch based on grid type?

@jbisits
Copy link
Collaborator

jbisits commented Jun 8, 2022

Yep that sounds good!

@navidcy
Copy link
Member Author

navidcy commented Jul 1, 2022

#55 added the 1D functionality!

@jbisits
Copy link
Collaborator

jbisits commented Jul 1, 2022

3D advection-diffusion to follow shortly!

@navidcy navidcy linked a pull request Jul 2, 2022 that will close this issue
Add 3D advection-diffusion #57
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navidcy navidcy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 3D advection-diffusion jbisits/PassiveTracerFlows.jl
2 participants
@navidcy @jbisits