Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3D advection-diffusion #57

Merged
merged 9 commits into from
Jul 2, 2022
Merged

Add 3D advection-diffusion #57

merged 9 commits into from
Jul 2, 2022

Commits on Jul 1, 2022

  1. First commit 

    All seems to be working except the test for a time varying flow in 3D fails. Not sure why yet.
    @jbisits
    jbisits committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    028f659 View commit details
    Browse the repository at this point in the history

  2. Fixed the problem 

    Had a wrong variable in `calc_N!`. Fixed now all tests pass. Need to do some beautifications so that indenting is the same.
    @jbisits
    jbisits committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    c0b32a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Beautifications 

    Code alignment and further homogenise docstrings.
    @jbisits
    jbisits committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    d9c65f5 View commit details
    Browse the repository at this point in the history

  2. η, κ, ι the x, y, z diffusivities + docstrings

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    b9a2435 View commit details
    Browse the repository at this point in the history

  3. some more η, κ -> κ, η

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    11f8158 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    18707d3 View commit details
    Browse the repository at this point in the history

  5. code alignment

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    23629fe View commit details
    Browse the repository at this point in the history

  6. reduce 3D problem size

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    8709e04 View commit details
    Browse the repository at this point in the history

  7. some code alignment + fix tests

    @navidcy
    navidcy committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    6240ff9 View commit details
    Browse the repository at this point in the history