Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.12 #53

Merged
merged 6 commits into from
Jan 26, 2024
Merged

V0.12 #53

merged 6 commits into from
Jan 26, 2024

Conversation

Donvlouss
Copy link
Contributor

Copy link

fmsc-bot bot commented Jan 16, 2024

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

Copy link

fmsc-bot bot commented Jan 16, 2024

Error parsing command: EOF found when expecting closing quote

Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Everything looks good, I didn't know about the path issue for embedded assets, that's a good catch.

I added a few nitpick but otherwise LGTM

let bind_group = device.create_bind_group(
Some("polyline_material_bind_group"),
&polyline_pipeline.material_layout,
&[BindGroupEntry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change it in this PR, but you can use BindGroupEntries::single() here.

src/polyline.rs Outdated Show resolved Hide resolved
Copy link

fmsc-bot bot commented Jan 16, 2024

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

Copy link

fmsc-bot bot commented Jan 16, 2024

Error parsing command: EOF found when expecting closing quote

@IceSentry IceSentry merged commit 81172b3 into ForesightMiningSoftwareCorporation:main Jan 26, 2024
1 check passed
@IceSentry IceSentry mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants