Upgrading to Bevy 0.12 #52
Conversation
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
| .vscode |
There was a problem hiding this comment.
I would suggest to remove additional changes from this file.
| .add_plugins(FrameTimeDiagnosticsPlugin::default()) | ||
| .add_plugins(LogDiagnosticsPlugin::default()) |
There was a problem hiding this comment.
Why you included these plugins into examples?
| @@ -14,20 +14,14 @@ pub mod prelude { | |||
| pub use crate::PolylinePlugin; | |||
| } | |||
|
|
|||
| pub const SHADER_HANDLE: HandleUntyped = | |||
| HandleUntyped::weak_from_u64(Shader::TYPE_UUID, 12823766040132746065); | |||
| pub const SHADER_HANDLE: Handle<Shader> = | |||
There was a problem hiding this comment.
Could you use embed_asset!? See https://bevyengine.org/news/bevy-0-12/#embedded-assets
| alpha_mode, | ||
| bind_group, | ||
| }) | ||
| panic!(); |
| "bevy_core_pipeline", | ||
| "bevy_render", | ||
| "bevy_asset", | ||
| ] } | ||
|
|
||
| [dependencies.naga] | ||
| features = ["glsl-in", "spv-out", "wgsl-out"] | ||
| version = "0.12" | ||
| version = "0.14" |
There was a problem hiding this comment.
Could you set it to 0.13? This is what bevy use.
|
closed by #53 |
Not saying the changes I made are the best way to make this work with Bevy
0.12but they do compile and run. 😅