Beta release ISO15118-20 #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
d71aa46
to
be33a5d
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
4562358
to
aba7a0d
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
2 times, most recently
from
f5dfe32
to
6790568
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
842ed32
to
3f2dc6c
Compare
barsnick
reviewed
Jun 21, 2024
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
619b7c7
to
f561e76
Compare
corneliusclaussen
force-pushed
the
testing/iso15118-20
branch
from
fbefa88
to
55209e8
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
55209e8
to
0d9d68b
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
0d9d68b
to
2935080
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
3 times, most recently
from
86e7666
to
14871bd
Compare
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
acaa9f3
to
53470ce
Compare
SebaLukas
requested review from
corneliusclaussen,
Pietfried,
james-ctc and
hikinggrass
as code owners
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
53470ce
to
fdaf2bc
Compare
james-ctc
reviewed
Sep 19, 2024
a-w50
reviewed
Sep 22, 2024
a-w50
reviewed
Sep 24, 2024
SebaLukas
force-pushed
the
testing/iso15118-20
branch
3 times, most recently
from
674074a
to
6268cfa
Compare
- Added config/config-sil-dc-d20.yaml for SIL testing - Added Evse15118D20 module - Modified PyEvJosev module for supported services - Use device config option - Additional umwc iso stop handlers - Added logging skeleton - Supporting tls negotiation strategy - Support for exi log messages - Logging format changes - DC_EV_TargetVoltageCurrent is now published - Added support for configurable keyfile password - Added v2g_setup_finished & current_demand_started var callback - Added signal start_cable_check - Added first simple control event - Added stop and unplug cmds to the auto exec commands. Now the ev stops the charging process after 15 seconds - Send control_event presentvoltagecurrent - Added the new feedback signals and foward the authorization status to the d20 state machine - Handle_session_setup() is now in use - Handle StopCharging - Adding v2g_message_id callback, v2g_message_xml & json are now really optional - Adding bidirectional to iso15118_charger interface - Updating logging_callback with LogLevels Co-authored-by: Cornelius Claussen <[email protected]> Co-authored-by: Sebastian Lukas <[email protected]> Signed-off-by: aw <[email protected]> Signed-off-by: Sebastian Lukas <[email protected]>
…, removed setup_done Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…ohamm::json Object Signed-off-by: Sebastian Lukas <[email protected]>
…onvert_v2g_message_type Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: aw <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…mode and if the mode supports bidi. Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
testing/iso15118-20
branch
from
b78e30e
to
c57baaf
Compare
corneliusclaussen
approved these changes
Sep 30, 2024
|
|
||
| update_powersupply_capabilities(get_powersupply_capabilities()); | ||
| if (caps.bidirectional) { |
There was a problem hiding this comment.
ok for now, but I'm not sure if this still works if the power supply capabilties are not yet available here. In this case they will default to safe defaults and the real values/bidi flag will come once connection to the power supply is established. Later this probably needs to go into update_powersupply_capabilities().
There was a problem hiding this comment.
Hmm, then the EvseManager should call call_setup from the iso15118_charger interface only if the power supply caps are available and not before.
There was a problem hiding this comment.
It may change any time, so a power supply may also sometimes be able to do bidi and some times not. Whenever that changes, we need to update the iso module. This is why we factored out e.g. set_charging_parameters from setup(). Setup() should only contain things that are fixed and available at start up, everything else should be runtime-modifiable, this includes the min/max power ratings and the bidi flags.
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding Evse15118D20 module for iso15118-20 beta support
Adding the new EVerest/libiso15118 to everest-core
Issue ticket number and link
Missing ISO15118-20 DC/DC BPT support in EVerest
Checklist before requesting a review