Adding suggestions + clang format fix

Signed-off-by: Sebastian Lukas <[email protected]>
EVerest · Jun 27, 2024 · 55209e8 · 55209e8
1 parent 4118687
commit 55209e8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/config/config-sil-dc-d20.yaml b/config/config-sil-dc-d20.yaml
@@ -44,7 +44,7 @@ active_modules:
         - module_id: imd
           implementation_id: main
   powersupply_dc:
-    module: JsDCSupplySimulator
+    module: DCSupplySimulator
   yeti_driver:
     module: JsYetiSimulator
     config_module:

diff --git a/modules/EvseManager/energy_grid/energyImpl.cpp b/modules/EvseManager/energy_grid/energyImpl.cpp
@@ -508,8 +508,8 @@ void energyImpl::handle_enforce_limits(types::energy::EnforcedLimits& value) {
                     session_log.evse(
                         true,
                         fmt::format("Change HLC Limits: {}W/{}A, target_voltage {}, actual_voltage {}, hack_bpt {}",
-                                    evseMaxLimits.maximum_power, evseMaxLimits.maximum_current,
-                                    target_voltage, actual_voltage, mod->is_actually_exporting_to_grid));
+                                    evseMaxLimits.maximum_power, evseMaxLimits.maximum_current, target_voltage,
+                                    actual_voltage, mod->is_actually_exporting_to_grid));
                     mod->r_hlc[0]->call_update_dc_maximum_limits(evseMaxLimits);
                     mod->charger->inform_new_evse_max_hlc_limits(evseMaxLimits);
 

diff --git a/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp b/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
@@ -343,20 +343,18 @@ void ISO15118_chargerImpl::handle_update_dc_maximum_limits(
                             iso2_unitSymbolType_W);
     v2g_ctx->evse_v2g_data.evse_maximum_power_limit_is_used = 1;
 
-    populate_physical_value_float(&v2g_ctx->evse_v2g_data.evse_maximum_voltage_limit,
-                                  maximum_limits.maximum_voltage, 1, iso2_unitSymbolType_V);
+    populate_physical_value_float(&v2g_ctx->evse_v2g_data.evse_maximum_voltage_limit, maximum_limits.maximum_voltage, 1,
+                                  iso2_unitSymbolType_V);
     v2g_ctx->evse_v2g_data.evse_maximum_voltage_limit_is_used = 1;
 }
 
 void ISO15118_chargerImpl::handle_update_dc_minimum_limits(
     types::iso15118_charger::DC_EVSEMinimumLimits& minimum_limits) {
 
     populate_physical_value_float(&v2g_ctx->evse_v2g_data.evse_minimum_current_limit,
-                                  static_cast<long long int>(minimum_limits.minimum_current), 1,
-                                  iso2_unitSymbolType_A);
+                                  static_cast<long long int>(minimum_limits.minimum_current), 1, iso2_unitSymbolType_A);
     populate_physical_value_float(&v2g_ctx->evse_v2g_data.evse_minimum_voltage_limit,
-                                  static_cast<long long int>(minimum_limits.minimum_voltage), 1,
-                                  iso2_unitSymbolType_V);
+                                  static_cast<long long int>(minimum_limits.minimum_voltage), 1, iso2_unitSymbolType_V);
 }
 
 void ISO15118_chargerImpl::handle_update_isolation_status(types::iso15118_charger::IsolationStatus& isolation_status) {

diff --git a/modules/Iso15118/D20Evse/charger/ISO15118_chargerImpl.cpp b/modules/Iso15118/D20Evse/charger/ISO15118_chargerImpl.cpp
@@ -130,7 +130,7 @@ void ISO15118_chargerImpl::ready() {
         try {
             controller->loop();
         } catch (const std::exception& e) {
-            EVLOG_error << "D20Evse chrashed: " << e.what();
+            EVLOG_error << "D20Evse crashed: " << e.what();
             publish_dlink_error(nullptr);
         }
 

diff --git a/types/iso15118_charger.yaml b/types/iso15118_charger.yaml
@@ -185,7 +185,7 @@ types:
         minimum: 0
         maximum: 1500
       maximum_discharge_current:
-        description: Maximum discharge current the EVSE can deliver in W
+        description: Maximum discharge current the EVSE can deliver in A
         type: number
         minimum: 0
         maximum: 10000
@@ -219,7 +219,7 @@ types:
         minimum: 0
         maximum: 1000000
       minimum_discharge_current:
-        description: Minimum discharge current the EVSE can deliver in W
+        description: Minimum discharge current the EVSE can deliver in A
         type: number
         minimum: 0
         maximum: 10000