Skip to content

Conversation

@achave11-ucsc
Copy link
Member

@achave11-ucsc achave11-ucsc commented Nov 19, 2025

Linked issue: DataBiosphere/azul-private#301

Checklist

Notes

  • Requested snapshot has already been deleted from the AnVIL catalogs

Author

  • PR is assigned to the author
  • Status of PR is In progress
  • Target branch is anvilprod
  • Name of PR branch matches hotfixes/<GitHub handle of author>/<issue#>-<slug>-anvilprod
  • PR is linked to the issue it hotfixes
  • Status of linked issue is In progress
  • PR description links to linked issue
  • PR title is Hotfix anvilprod: followed by title of linked issue
  • PR title references the linked issue

Author (hotfixes)

  • Added h tag to commit title or this PR does not include a temporary hotfix
  • Added H tag to commit title or this PR does not include a permanent hotfix
  • Added hotfix label to PR
  • This PR is labeled partial or represents a permanent hotfix

Author (before every review)

  • Rebased PR branch on anvilprod, squashed fixups from prior reviews
  • Ran make requirements_update or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt
  • PR is not a draft
  • PR is awaiting requested review from system administrator
  • Status of PR is Review requested
  • PR is assigned to only the system administrator

System administrator (after approval)

  • Actually approved the PR
  • Decided if PR can be labeled no sandbox
  • A comment to this PR details the completed security design review
  • PR title is appropriate as title of merge commit
  • N reviews label is accurate
  • Status of PR is Approved
  • PR is assigned to only the operator

Operator

  • Squashed PR branch and rebased onto anvilprod
  • Sanity-checked history
  • Pushed PR branch to GitHub

Operator (deploy runner image)

  • Ran _select anvilprod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner

Operator (sandbox build)

  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvilprod or PR is labeled no sandbox
  • Build passes in hammerbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in hammerbox deployment or PR is labeled no sandbox

Operator (merge the branch)

  • All status checks passed and the PR is mergeable
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub
  • Status of PR is Merged stable

Operator (main build)

  • Pushed merge commit to GitLab anvilprod
  • Build passes on GitLab anvilprod
  • Reviewed build logs for anomalies on GitLab anvilprod
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab anvilprod
  • Status of linked issue is Stable

Operator (reindex)

  • Deindexed all unreferenced catalogs in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Deindexed specific sources in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Indexed specific sources in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Started reindex in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Checked for, triaged and possibly requeued messages in both fail queues in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Emptied fail queues in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Restarted the Data Browser pipeline for the ucsc/anvil/anvilprod branch on GitLab in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Restarted deploy_browser job in the GitLab pipeline for this PR in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Created backport PR and linked to it in a comment on this PR see end of CL

Operator (mirroring)

  • Started mirroring in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Checked for, triaged and possibly requeued messages in mirror fail queue in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Emptied mirror fail queue in anvilprod or neither this PR nor a failed, prior promotion requires it

Operator

  • PR is assigned to only the system administrator

System administrator

  • Backported changes to develop
  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@achave11-ucsc achave11-ucsc self-assigned this Nov 19, 2025
@achave11-ucsc achave11-ucsc added hotfix [process] An PR with an urgent fix for prod reindex:anvilprod [process] PR requires reindexing anvilprod reindex:partial [process] PR allows for (de)indexing a specific source or catalog labels Nov 19, 2025
@achave11-ucsc achave11-ucsc changed the title Hotfix anvilprod: Remove snapshot 0d3a9994 from anvil catalogs (DataBiosphere/azul-private#301) Hotfix anvilprod: Remove ANVIL_African_American_Seq_HGV from all AnVIL catalogs (DataBiosphere/azul-private#301) Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.35%. Comparing base (75bcc52) to head (b48d9ae).

Additional details and impacted files
@@              Coverage Diff              @@
##           anvilprod    #7578      +/-   ##
=============================================
+ Coverage      85.26%   85.35%   +0.09%     
=============================================
  Files            156      156              
  Lines          23069    22496     -573     
=============================================
- Hits           19669    19201     -468     
+ Misses          3400     3295     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coveralls
Copy link

Coverage Status

coverage: 85.568%. remained the same
when pulling b48d9ae on hotfixes/achave11-ucsc/rm-snapshot-0d3a9994-anvil11
into 75bcc52 on anvilprod.

@hannes-ucsc
Copy link
Member

Security design review

  • Security design review completed; this PR does not
    • … affect authentication; for example:
      • OAuth 2.0 with the application (API or Swagger UI)
      • Authentication of developers with Google Cloud APIs
      • Authentication of developers with AWS APIs
      • Authentication with a GitLab instance in the system
      • Password and 2FA authentication with GitHub
      • API access token authentication with GitHub
      • Authentication with Terra
    • … affect the permissions of internal users like access to
      • Cloud resources on AWS and GCP
      • GitLab repositories, projects and groups, administration
      • an EC2 instance via SSH
      • GitHub issues, pull requests, commits, commit statuses, wikis, repositories, organizations
    • … affect the permissions of external users like access to
      • TDR snapshots
    • … affect permissions of service or bot accounts
      • Cloud resources on AWS and GCP
    • … affect audit logging in the system, like
      • adding, removing or changing a log message that represents an auditable event
      • changing the routing of log messages through the system
    • … affect monitoring of the system
    • … introduce a new software dependency like
      • Python packages on PYPI
      • Command-line utilities
      • Docker images
      • Terraform providers
    • … add an interface that exposes sensitive or confidential data at the security boundary
    • … affect the encryption of data at rest
    • … require persistence of sensitive or confidential data that might require encryption at rest
    • … require unencrypted transmission of data within the security boundary
    • … affect the network security layer; for example by
      • modifying, adding or removing firewall rules
      • modifying, adding or removing security groups
      • changing or adding a port a service, proxy or load balancer listens on
  • Documentation on any unchecked boxes is provided in comments below

@hannes-ucsc hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Nov 19, 2025
@hannes-ucsc hannes-ucsc removed their assignment Nov 19, 2025
@achave11-ucsc achave11-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 reviews [process] Lead didn't request any changes hotfix [process] An PR with an urgent fix for prod reindex:anvilprod [process] PR requires reindexing anvilprod reindex:partial [process] PR allows for (de)indexing a specific source or catalog sandbox [process] Resolution is being verified in sandbox deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants