Fix: Effective value of azul_current_{catalog,source} is not obvious (#7503) #7550

nadove-ucsc · 2025-11-05T01:07:41Z

Linked issues: #7503

Checklist

Author

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to ~~only~~ the peer

Peer reviewer (after approval)

Note that when requesting changes, the PR must be assigned back to the author.

Actually approved the PR
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to ~~only~~ the system administrator

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to only the operator

Operator

Checked reindex:… labels and r commit title tag
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR does not require mirroring dev}
Started mirroring in anvildev _{or this PR does not require mirroring anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR does not require mirroring dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}
Emptied mirror fail queue in dev _{or this PR does not require mirroring dev}
Emptied mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

codecov · 2025-11-05T01:25:31Z

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.36%. Comparing base (bd301a9) to head (4177f3b).

Files with missing lines	Patch %	Lines
src/azul/__init__.py	12.50%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7550      +/-   ##
===========================================
- Coverage    85.37%   85.36%   -0.02%     
===========================================
  Files          156      156              
  Lines        22496    22499       +3     
===========================================
  Hits         19206    19206              
- Misses        3290     3293       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coveralls · 2025-11-05T01:26:45Z

coverage: 85.578% (-0.01%) from 85.59%
when pulling 4177f3b on issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious
into bd301a9 on develop.

dsotirho-ucsc · 2025-11-07T00:32:33Z

scripts/reindex.py

-                        config.catalogs[config.current_catalog].name
-                    ],
                    choices=config.catalogs,
                    help='The names of the catalogs to reindex.')


Suggested change

help='The names of the catalogs to reindex.')

help='Limit reindexing to a subset of the configured catalogs. This option can alternatively be set via an environment variable.')

scripts/reindex.py

dsotirho-ucsc

Approved

hannes-ucsc · 2025-11-07T18:39:40Z

scripts/reindex.py

+    if args.catalogs is None:
+        catalog_origin = 'environment variable'
+        if config.current_catalog is None:
+            catalog_origin += ' (unset)'


Using catalog(s) specified via environment variable (unset): …

sounds confusing. How can something that's not set specify something? Maybe use a separate, third source to indicate this case?

nadove-ucsc · 2025-11-07T21:43:05Z

Fixup commits had to be squashed during conflict resolution.

...to expose to callers whether the variable is set or not

…7503)

hannes-ucsc · 2025-11-08T01:19:36Z

scripts/mirror.py

+                             'All sources must be public. If no values are passed, this argument will be set from the '
+                             'environment variable ``azul_current_sources``. If that variable is unset, all sources in '


I saw your two edits to this comment but I'm still confused. Where is the logging that shows the effective value and its provenance?

nadove-ucsc self-assigned this Nov 5, 2025

nadove-ucsc linked an issue Nov 5, 2025 that may be closed by this pull request

Effective value of azul_current_{catalog,source} is not obvious #7503

Open

nadove-ucsc force-pushed the issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious branch from 734fa0f to 9f13681 Compare November 5, 2025 01:11

nadove-ucsc force-pushed the issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious branch from 9f13681 to e2d4a74 Compare November 5, 2025 01:36

nadove-ucsc assigned dsotirho-ucsc Nov 5, 2025

nadove-ucsc requested a review from dsotirho-ucsc November 5, 2025 02:14

dsotirho-ucsc reviewed Nov 7, 2025

View reviewed changes

dsotirho-ucsc removed their assignment Nov 7, 2025

nadove-ucsc force-pushed the issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious branch 2 times, most recently from 5058166 to e9f12d7 Compare November 7, 2025 02:42

nadove-ucsc requested a review from dsotirho-ucsc November 7, 2025 06:11

nadove-ucsc assigned dsotirho-ucsc Nov 7, 2025

dsotirho-ucsc previously approved these changes Nov 7, 2025

View reviewed changes

dsotirho-ucsc marked this pull request as ready for review November 7, 2025 17:20

dsotirho-ucsc requested a review from hannes-ucsc as a code owner November 7, 2025 17:20

dsotirho-ucsc assigned hannes-ucsc and unassigned dsotirho-ucsc Nov 7, 2025

hannes-ucsc requested changes Nov 7, 2025

View reviewed changes

hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Nov 7, 2025

hannes-ucsc assigned nadove-ucsc and unassigned hannes-ucsc and nadove-ucsc Nov 7, 2025

nadove-ucsc dismissed dsotirho-ucsc’s stale review via dbc52ee November 7, 2025 20:54

nadove-ucsc force-pushed the issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious branch 2 times, most recently from dbc52ee to 50e4567 Compare November 7, 2025 21:42

nadove-ucsc added 2 commits November 7, 2025 13:57

Use consistent template for argument help message

67506b7

fixup! Use consistent template for argument help message

2457a83

nadove-ucsc added 3 commits November 7, 2025 13:57

Document default values for catalogs and sources in reindex script

0d66d59

Remove default value for Config.current_sources

a6d1163

...to expose to callers whether the variable is set or not

Fix: Effective value of azul_current_{catalog,source} is not obvious (#…

4177f3b

…7503)

nadove-ucsc force-pushed the issues/nadove-ucsc/7503-effective-value-azul-current-catalog-sources-not-obvious branch from 50e4567 to 4177f3b Compare November 7, 2025 22:47

nadove-ucsc requested a review from hannes-ucsc November 7, 2025 23:02

nadove-ucsc assigned hannes-ucsc Nov 7, 2025

hannes-ucsc requested changes Nov 8, 2025

View reviewed changes

hannes-ucsc removed their assignment Nov 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Effective value of azul_current_{catalog,source} is not obvious (#7503) #7550

Fix: Effective value of azul_current_{catalog,source} is not obvious (#7503) #7550

Uh oh!

nadove-ucsc commented Nov 5, 2025 •

edited by dsotirho-ucsc

Loading

Uh oh!

codecov bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

coveralls commented Nov 5, 2025 •

edited

Loading

Uh oh!

dsotirho-ucsc Nov 7, 2025

Uh oh!

Uh oh!

dsotirho-ucsc left a comment

Uh oh!

hannes-ucsc Nov 7, 2025 •

edited

Loading

Uh oh!

nadove-ucsc commented Nov 7, 2025

Uh oh!

hannes-ucsc Nov 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	help='The names of the catalogs to reindex.')
	help='Limit reindexing to a subset of the configured catalogs. This option can alternatively be set via an environment variable.')

		'All sources must be public. If no values are passed, this argument will be set from the '
		'environment variable ``azul_current_sources``. If that variable is unset, all sources in '

Fix: Effective value of azul_current_{catalog,source} is not obvious (#7503) #7550

Are you sure you want to change the base?

Fix: Effective value of azul_current_{catalog,source} is not obvious (#7503) #7550

Uh oh!

Conversation

nadove-ucsc commented Nov 5, 2025 • edited by dsotirho-ucsc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Author

Author (partiality)

Author (reindex)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsotirho-ucsc Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nadove-ucsc commented Nov 7, 2025

Uh oh!

hannes-ucsc Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nadove-ucsc commented Nov 5, 2025 •

edited by dsotirho-ucsc

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

codecov bot commented Nov 5, 2025 •

edited

Loading

coveralls commented Nov 5, 2025 •

edited

Loading

hannes-ucsc Nov 7, 2025 •

edited

Loading