Enable mirroring in anvildev and anvilbox (#7154, #7214) #7223

nadove-ucsc · 2025-06-16T21:59:37Z

Connected issues: #7154, #7214

Checklist

Author

PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
On ZenHub, PR is connected to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a connected issue _{or comment in PR explains why they're different}
PR title references all connected issues
For each connected issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all connected issues}
This PR partially resolves each of the connected issues _{or does not have the partial label}

Author (chains)

This PR is blocked by previous PR in the chain _{or is not chained to another PR}
The blocking PR is labeled base _{or this PR is not chained to another PR}
This PR is labeled chained _{or is not chained to another PR}

Author (reindex, API changes)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}
This PR and its connected issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any connected issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues connected to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}

Peer reviewer (after approval)

Actually approved the PR
PR is not a draft
Ticket is in Review requested column
PR is awaiting requested review from system administrator
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled connected issues as demo or no demo
Commented on connected issues about demo expectations _{or all connected issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Moved connected issues to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Mirrored anvilbox
PR is assigned to only the operator

Operator

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Moved connected issues to Merged lower column in ZenHub
Moved blocked issues to Triage _{or no issues are blocked on the connected issues}
Pushed merge commit to GitHub

Operator (chain shortening)

Changed the target branch of the blocked PR to develop _{or this PR is not labeled base}
Removed the chained label from the blocked PR _{or this PR is not labeled base}
Removed the blocking relationship from the blocked PR _{or this PR is not labeled base}
Removed the base label from this PR _{or this PR is not labeled base}

Operator (after pushing the merge commit)

Operator (reindex)

System administrator

Mirrored anvildev
PR is assigned to only the operator

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

codecov · 2025-06-17T07:52:13Z

Codecov Report

❌ Patch coverage is 70.19231% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.33%. Comparing base (cbef132) to head (4b41434).

Files with missing lines	Patch %	Lines
test/integration_test.py	0.00%	22 Missing ⚠️
src/azul/plugins/repository/tdr_anvil/__init__.py	54.54%	5 Missing ⚠️
src/azul/azulclient.py	84.61%	2 Missing ⚠️
src/azul/indexer/mirror_service.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7223      +/-   ##
===========================================
- Coverage    85.36%   85.33%   -0.04%     
===========================================
  Files          156      156              
  Lines        22484    22548      +64     
===========================================
+ Hits         19194    19241      +47     
- Misses        3290     3307      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coveralls · 2025-06-17T09:29:02Z

coverage: 85.55% (-0.03%) from 85.578%
when pulling 4b41434 on issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding
into cbef132 on develop.

dsotirho-ucsc

Approved.

hannes-ucsc

This will get conflicts once the backport I just approved land on develop.

It's not evident from the title of that commit that removes the snapshot what the defect is. Either add a ticket reference or describe the defect in the body of the commit message. Probably the former is warranted so that we can point our collaborators at it.

The base branch was changed.

hannes-ucsc

While the link in the message body of the middle commit is helpful, the body should be self-contained and include a description of the alleged defect.

nadove-ucsc · 2025-07-16T03:12:15Z

Agreed on Slack that the PR does not need specific reindex instructions.

nadove-ucsc added reindex:anvildev [process] PR requires reindexing anvildev reindex:anvilprod [process] PR requires reindexing anvilprod labels Jun 16, 2025

github-actions bot added the orange label Jun 16, 2025

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch 3 times, most recently from 85448b8 to 1cb13db Compare June 17, 2025 07:28

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch from 1cb13db to 9dc69e5 Compare June 26, 2025 06:39

nadove-ucsc assigned dsotirho-ucsc Jun 26, 2025

nadove-ucsc requested a review from dsotirho-ucsc June 26, 2025 07:05

dsotirho-ucsc previously approved these changes Jun 26, 2025

View reviewed changes

dsotirho-ucsc marked this pull request as ready for review June 26, 2025 18:14

dsotirho-ucsc requested a review from hannes-ucsc as a code owner June 26, 2025 18:14

dsotirho-ucsc assigned hannes-ucsc and unassigned dsotirho-ucsc Jun 26, 2025

hannes-ucsc requested changes Jul 1, 2025

View reviewed changes

hannes-ucsc added the 1 review [process] Lead requested changes once label Jul 1, 2025

hannes-ucsc removed their assignment Jul 1, 2025

nadove-ucsc added the chained [process] PR needs to based of develop before merging label Jul 3, 2025

nadove-ucsc changed the base branch from develop to backports/36999c52 July 3, 2025 00:30

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch from 9dc69e5 to a0ad747 Compare July 3, 2025 00:30

achave11-ucsc changed the base branch from backports/36999c52 to develop July 9, 2025 03:46

achave11-ucsc removed the chained [process] PR needs to based of develop before merging label Jul 9, 2025

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch from a0ad747 to 8056e9e Compare July 9, 2025 06:56

nadove-ucsc requested a review from hannes-ucsc July 9, 2025 07:27

nadove-ucsc assigned hannes-ucsc Jul 9, 2025

hannes-ucsc requested changes Jul 14, 2025

View reviewed changes

hannes-ucsc removed their assignment Jul 14, 2025

nadove-ucsc removed the reindex:partial [process] PR allows for (de)indexing a specific source or catalog label Jul 15, 2025

hannes-ucsc added 1 review [process] Lead requested changes once and removed 2 reviews [process] Lead requested changes twice labels Jul 16, 2025

nadove-ucsc requested a review from hannes-ucsc July 16, 2025 03:29

nadove-ucsc assigned hannes-ucsc and unassigned hannes-ucsc Jul 16, 2025

This was linked to issues Sep 11, 2025

AnVIL uses uncommon encoding for MD5 digests #7154

Open

Enable mirroring in anvildev and anvilbox #7214

Open

hannes-ucsc assigned nadove-ucsc Sep 29, 2025

hannes-ucsc removed the orange label Oct 2, 2025

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch from 0d5583f to f7c0406 Compare October 11, 2025 20:26

nadove-ucsc added 11 commits October 29, 2025 17:20

Assert mirroring is enabled when handling messages

74976e2

Assert mirrored sources are public

a97eb69

Move file size check from mirror_file to mirror_partition

b42546a

Refactor mirror controller test

ad63770

Refactor IT source selection

59cfa83

[u 1/6] Use consistent value for pop flag (#7066)

029507d

[u 2/6] Rename mklist to mksrcs (#7066)

04ac4db

[u 3/6] Consistently use mksrcs function (#7066)

6c93459

[u 4/6] Configure max mirrored file size per catalog (#7066)

1598e5f

[u 5/6] Convert source config to dictionary (#7066)

401f5a2

[u 6/6] Configure mirroring per source (#7066)

28cb74e

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch 3 times, most recently from 3631b08 to 56a8e3c Compare October 31, 2025 00:36

nadove-ucsc added 3 commits October 30, 2025 18:17

Verify download size in mirror service

9c9b20d

[r] Fix: AnVIL uses uncommon encoding for MD5 digests (#7154)

40e88db

Enable mirroring in anvildev and anvilbox (#7214)

4b41434

nadove-ucsc force-pushed the issues/nadove-ucsc/7154-anvil-uses-nonstandard-md5-enconding branch from 56a8e3c to 4b41434 Compare October 31, 2025 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable mirroring in anvildev and anvilbox (#7154, #7214) #7223

Enable mirroring in anvildev and anvilbox (#7154, #7214) #7223

Uh oh!

nadove-ucsc commented Jun 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 17, 2025 •

edited

Loading

Uh oh!

coveralls commented Jun 17, 2025 •

edited

Loading

Uh oh!

dsotirho-ucsc left a comment

Uh oh!

hannes-ucsc left a comment

Uh oh!

hannes-ucsc left a comment

Uh oh!

nadove-ucsc commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Enable mirroring in anvildev and anvilbox (#7154, #7214) #7223

Are you sure you want to change the base?

Enable mirroring in anvildev and anvilbox (#7154, #7214) #7223

Uh oh!

Conversation

nadove-ucsc commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Author

Author (partiality)

Author (chains)

Author (reindex, API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

System administrator

Operator

Operator (chain shortening)

Operator (after pushing the merge commit)

Operator (reindex)

System administrator

Operator

Shorthand for review comments

Uh oh!

codecov bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

nadove-ucsc commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nadove-ucsc commented Jun 16, 2025 •

edited

Loading

codecov bot commented Jun 17, 2025 •

edited

Loading

coveralls commented Jun 17, 2025 •

edited

Loading