Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Improve order flow) Make ticket id a private attribute #4032

Merged
merged 5 commits into from
Dec 19, 2024
Merged

(Improve order flow) Make ticket id a private attribute #4032

merged 5 commits into from
Dec 19, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Dec 18, 2024

Description

Ticket id is not something that customers provide, so it should be a private attribute

Added

Changed

Fixed

  • ticket_id is a private attribute on the Order model

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner December 18, 2024 14:42
@diitaz93 diitaz93 self-requested a review December 19, 2024 07:38
diitaz93
diitaz93 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleaning!

cg/services/order_validation_service/models/order.py Outdated Show resolved Hide resolved
cg/services/order_validation_service/models/order.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@islean islean merged commit 42221b0 into improve-order-flow-main Dec 19, 2024
8 checks passed
@islean islean deleted the make-ticket-number-private branch December 19, 2024 10:45
@diitaz93 diitaz93 mentioned this pull request Dec 19, 2024
Merged
15 tasks
diitaz93 added a commit that referenced this pull request Dec 19, 2024
@diitaz93
Make type of ticket clear in store services (#4034)
cf6482b 
in #4032 Order ticket was made int. The store services were expecting a str. This PR changes those occurrences by casting the variable to a str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islean @diitaz93