Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type of ticket clear in store services #4034

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Dec 19, 2024

Description

in #4032 Order ticket was made int. The store services were expecting a str. This PR changes those occurrences by casting the variable to a str

Added

  • Explicit str casting of ticket when necessary

Changed

  • Make use of the CRUD function add_order instead of calling the constructor

Fixed

  • Some calls to the old ticket attribute of the orders, changed to _generated_tickket_id

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@diitaz93 diitaz93 requested a review from a team as a code owner December 19, 2024 12:14
@diitaz93 diitaz93 changed the base branch from master to improve-order-flow-main December 19, 2024 12:14
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@diitaz93 diitaz93 merged commit cf6482b into improve-order-flow-main Dec 19, 2024
8 checks passed
@diitaz93 diitaz93 deleted the small-patch-to-ticket branch December 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants