Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug causing mip workflow start to fail #2769

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix bug causing mip workflow start to fail #2769

merged 3 commits into from
Dec 14, 2023

Conversation

seallard
Copy link
Contributor

Description

Closes #2768.

Fixed

  • Bug due to modifying a set of panels while iterating over it

How to test

  • Do cg workflow mip-dna start savedcoyote

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@seallard seallard requested a review from a team as a code owner December 14, 2023 10:34
@seallard seallard changed the title Do not modify set while iterating over it Fix bug causing mip workflow start to fail Dec 14, 2023
islean
islean approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seallard seallard merged commit a1a4976 into master Dec 14, 2023
7 checks passed
@seallard seallard deleted the fix-panel-bug branch December 14, 2023 10:45
@henrikstranneheim
Copy link
Contributor

@seallard Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIP workflow start fails for specific case
3 participants
@seallard @henrikstranneheim @islean