Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run panel PANELAPP-GREEN by default in all MIP runs #2700

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

beatrizsavinhas
Copy link
Contributor

@beatrizsavinhas beatrizsavinhas commented Nov 21, 2023

Description

Add panel PANELAPP-GREEN to all MIP runs.
Related to issue #2698

Added

  • PANELAPP-GREEN to run by default

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-PANELAPP-GREEN-to-mip -a

How to test

  • Attempt to run a case with a panel not in master list with cg and note the new panel being fetched from Scout, e.g.
     cg set case justhusky -g OPHTHALMO
     cg workflow mip-dna start justhusky -d

Expected test outcome

  • Check that the new panel is being fetched from Scout when running a case with a panel not in master list
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by BSV
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner November 21, 2023 11:10
@beatrizsavinhas
Copy link
Contributor Author

@dnil Is this the correct way to do this? Could you help me with testing also? 🤔

@beatrizsavinhas beatrizsavinhas marked this pull request as draft November 21, 2023 11:28
cg/meta/workflow/mip.py Outdated Show resolved Hide resolved
@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review November 29, 2023 14:21
@beatrizsavinhas
Copy link
Contributor Author

beatrizsavinhas commented Dec 6, 2023

Testing

With master:

20d [hiseq.clinical@hasta:~] [S_base] 48s $ cg workflow mip-dna start justhusky -d
(...)
Case justhusky exists in Status DB
Running command /home/proj/stage/bin/miniconda3/envs/S_scout/bin/scout --config /home/proj/stage/servers/config/hasta.scilifelab.se/scout-stage.yaml export panel --bed OPHTHALMO OMIM-AUTO --build 37

Only OPHTHALMO and OMIM-AUTO loaded.

After deploying this branch:

20d [hiseq.clinical@hasta:~] [S_base] 50s $ cg workflow mip-dna start justhusky -d
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Called undefined __fields__ on HousekeeperAPI, please wrap
Case justhusky exists in Status DB
Starting full MIP analysis workflow for case justhusky
Flow cell check is not applicable - the case is either down sampled or external.
Found file earlycasualcaiman/2019-05-08/HHT5NDSXX_HapMap_S26_L001_R1_001.fastq.gz
Found file earlycasualcaiman/2019-05-08/HHT5NDSXX_HapMap_S26_L001_R2_001.fastq.gz
Found file slowlycivilbuck/2019-05-08/HHT5NDSXX_HapMap_S27_L001_R1_001.fastq.gz
Found file slowlycivilbuck/2019-05-08/HHT5NDSXX_HapMap_S27_L001_R2_001.fastq.gz
Found file hugelymodelbat/2019-05-08/HHT5NDSXX_HapMap_S28_L001_R1_001.fastq.gz
Found file hugelymodelbat/2019-05-08/HHT5NDSXX_HapMap_S28_L001_R2_001.fastq.gz
Case justhusky exists in Status DB
Case justhusky exists in Status DB
Running command /home/proj/stage/bin/miniconda3/envs/S_scout/bin/scout --config /home/proj/stage/servers/config/hasta.scilifelab.se/scout-stage.yaml export panel --bed OPHTHALMO PANELAPP-GREEN OMIM-AUTO --build 37

Panels OPHTHALMO, PANELAPP-GREEN and OMIM-AUTOloaded.

Panel PANELAPP-GREEN loaded successfully!

@beatrizsavinhas beatrizsavinhas changed the title Run panel PANELAPP-GREEN by default all MIP runs Run panel PANELAPP-GREEN by default in all MIP runs Dec 6, 2023
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diitaz93 diitaz93 linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@beatrizsavinhas beatrizsavinhas merged commit 88e7d3d into master Dec 6, 2023
9 checks passed
@beatrizsavinhas beatrizsavinhas deleted the add-PANELAPP-GREEN-to-mip branch December 6, 2023 15:43
@beatrizsavinhas
Copy link
Contributor Author

Deployed to production by BSV:

20d [hiseq.clinical@hasta:~] [base] 3m43s $ bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-prod.sh -e P_cg -t cg -b master -a
(..)
done.
Log deploy... done.
cg, version 53.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PANELAPP-GREEN to all MIP runs, like OMIM-AUTO
3 participants