Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase case id range #2684

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Increase case id range #2684

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77a5fe5
Generate unique petnames
seallard Nov 13, 2023
491026e
Merge branch 'master' into running-out-of-case-names
seallard Nov 14, 2023
5a3a274
Add separate method for generating case ids
seallard Nov 14, 2023
72554a4
Bump characters for case id
seallard Nov 14, 2023
58d1472
Formatting
seallard Nov 14, 2023
0720f5d
Add type hints
seallard Nov 15, 2023
da687ed
Merge branch 'master' into running-out-of-case-names
seallard Nov 27, 2023
3bc653c
Merge branch 'master' into running-out-of-case-names
seallard Dec 6, 2023
e5f818d
Add requested doc string
seallard Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions cg/store/api/add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,7 @@ def add_case(
) -> Case:
"""Build a new Case record."""

# generate a unique case id
while True:
internal_id = petname.Generate(2, separator="")
if self.get_case_by_internal_id(internal_id) is None:
break
else:
LOG.debug(f"{internal_id} already used - trying another id")

internal_id: str = self.generate_unique_petname()
seallard marked this conversation as resolved.
Show resolved Hide resolved
return Case(
cohorts=cohorts,
data_analysis=str(data_analysis),
Expand Down