Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase case id range #2684

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Increase case id range #2684

merged 9 commits into from
Dec 6, 2023

Conversation

seallard
Copy link
Contributor

@seallard seallard commented Nov 13, 2023 •
edited
Loading

Description

Apparently we are running out of unique id:s for our cases. This PR increases the range of possible case ids by increasing the char length for them.

Fixed

  • Increase number of possible case id:s

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@seallard seallard requested a review from a team as a code owner November 13, 2023 15:21
islean
islean reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative but I think this has a risk of introducing some very rare bugs which might be hard to sniff out.

cg/store/api/add.py Outdated Show resolved Hide resolved
@seallard seallard requested a review from Vince-janv November 14, 2023 08:57
ChrOertlin
ChrOertlin reviewed Nov 14, 2023
View reviewed changes
cg/store/api/add.py Outdated Show resolved Hide resolved
henrikstranneheim
henrikstranneheim reviewed Nov 14, 2023
View reviewed changes
cg/store/api/add.py Outdated Show resolved Hide resolved
cg/store/api/add.py Outdated Show resolved Hide resolved
@seallard
Copy link
Contributor Author

I guess this is not important

@seallard seallard closed this Nov 27, 2023
@seallard seallard reopened this Nov 27, 2023
Vince-janv
Vince-janv approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Do we have any length restrictions in the database, that we need to update?

UPDATE: it's varchar(32) so we should be safe

cg/store/api/add.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seallard seallard merged commit 7050b06 into master Dec 6, 2023
8 checks passed
@seallard seallard deleted the running-out-of-case-names branch December 6, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vince-janv Vince-janv Vince-janv approved these changes

@henrikstranneheim henrikstranneheim Awaiting requested review from henrikstranneheim

@islean islean Awaiting requested review from islean

@ChrOertlin ChrOertlin Awaiting requested review from ChrOertlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seallard @henrikstranneheim @ChrOertlin @islean @Vince-janv