Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stan and PyRenew model comparison doc #9

Merged
merged 40 commits into from
Sep 6, 2024
Merged

Conversation

damonbayer
Copy link
Collaborator

@damonbayer damonbayer commented Sep 4, 2024

Doc can be rendered by executing poetry run quarto render notebooks/model_comp.qmd from within the pyrenew-covid-wastewater directory.

@damonbayer damonbayer marked this pull request as ready for review September 4, 2024 23:02
Copy link

@AFg6K7h4fhy2 AFg6K7h4fhy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred my review to others for comparison section. The other changes (minor) look good.

Copy link
Collaborator

@sbidari sbidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run the wwinference.Rmd before the model comparison demo renders as the demo uses .csv files which are not tracked. I would add a note at the beginning of the model_comp.qmd to indicate this.

@damonbayer
Copy link
Collaborator Author

You need to run the wwinference.Rmd before the model comparison demo renders as the demo uses .csv files which are not tracked. I would add a note at the beginning of the model_comp.qmd to indicate this.

addressed in 3ec45c1

@sbidari
Copy link
Collaborator

sbidari commented Sep 6, 2024

Looks good to me!

@damonbayer damonbayer merged commit e40e021 into main Sep 6, 2024
1 check passed
@damonbayer damonbayer deleted the dmb_demo_model_comp branch September 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants