-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stan and PyRenew model comparison doc #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred my review to others for comparison section. The other changes (minor) look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run the wwinference.Rmd
before the model comparison demo renders as the demo uses .csv
files which are not tracked. I would add a note at the beginning of the model_comp.qmd
to indicate this.
addressed in 3ec45c1 |
Looks good to me! |
Doc can be rendered by executing
poetry run quarto render notebooks/model_comp.qmd
from within thepyrenew-covid-wastewater
directory.