Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time column from output #276

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Remove time column from output #276

merged 2 commits into from
Jan 7, 2025

Conversation

damonbayer
Copy link
Collaborator

Calling this column time was ill-defined and wasn't really used for anything. Caused me some confusion when working on multiple data streams.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.48%. Comparing base (9c9d86b) to head (12f28d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   16.54%   16.48%   -0.06%     
==========================================
  Files          21       21              
  Lines        1481     1480       -1     
==========================================
- Hits          245      244       -1     
  Misses       1236     1236              
Flag Coverage Δ
hewr 47.68% <ø> (-0.11%) ⬇️
pipelines 0.00% <ø> (ø)
pyrenew_hew 1.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @damonbayer!

@dylanhmorris dylanhmorris merged commit e07eab0 into main Jan 7, 2025
15 checks passed
@dylanhmorris dylanhmorris deleted the dmb_off_by_one branch January 7, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants