Provide setup instructions for installing binderhub-service #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partial livestream of me trying out and making this PR here: https://www.youtube.com/watch?v=WMymAqFd6mQ |
yuvipanda
force-pushed
the
install-docs
branch
from
93b7555 to
db54e93
Compare
yuvipanda
force-pushed
the
install-docs
branch
from
98db189 to
dc22ee0
Compare
Worked through these with @simaattar2003 and made these changes. Co-authored-by: simaattar2003 <[email protected]>
yuvipanda
force-pushed
the
install-docs
branch
from
9dfee02 to
51915c8
Compare
yuvipanda
force-pushed
the
install-docs
branch
from
a417e8e to
0afa27d
Compare
for more information, see https://pre-commit.ci
consideRatio
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thank you for writing these @yuvipanda!!!
For reference, some related content:
- there are some development setup notes at Live notes towards a test deployment and demo #19 (comment)
- Testing of build/push is done in our CI system as well, where we use
curlwhich can end with a success message rather than failed to launch:
binderhub-service/.github/workflows/test-chart.yaml
Lines 195 to 197 in b2a3c43
Comment on lines
+158
to
+177
| 10. Let's verify that _image building and pushing_ works. Access the binderhub pod by following the | ||
| same instructions as step 3. But this time, you should see a binderhub page very similar to that | ||
| on [mybinder.org](https://mybinder.org). You can test build a repository here - I recommend trying | ||
| out `binder-examples/requirements`. It might take a while to build, but you should be able to see | ||
| logs in the UI. It should succeed at _pushing_ the github image, but will fail to launch. The last | ||
| lines in the log in the UI should look like: | ||
|
|
||
| ``` | ||
| Successfully pushed europe-west10-docker.pkg.dev/binderhub-service-development/bh-service-test/binderbinder-2dexamples-2drequirements-55ab5c:50533eb470ee6c24e872043d30b2fee463d6943fBuilt image, launching... | ||
| Launching server... | ||
| Launch attempt 1 failed, retrying... | ||
| Launch attempt 2 failed, retrying... | ||
| ``` | ||
|
|
||
| You can also go back to the Google Artifact Registry repository you created earlier to verify that the built | ||
| image is indeed there. | ||
|
|
||
| 11. Now that we have verified this is working, we can disable the binderhub UI as we will not be using it. | ||
| Remove the `config.BinderHub.enable_api_only_mode` configuration from the binderhub config, and redeploy | ||
| using the command from step 9. |
There was a problem hiding this comment.
This is acceptable as it is. An alternative test can be to do:
# this is the test from the github workflow testing things as well btw
curl http://localhost:8585/build/gh/binderhub-ci-repos/cached-minimal-dockerfile/HEAD?build_only=trueI think I'd favor use of curl as it highlights this is the role of binderhub-service now - API level access to build/push to be consumed by non-binderhub provided UI.
There was a problem hiding this comment.
I'd like to keep this one as is for now, hope that's ok.
There was a problem hiding this comment.
I also spent today with Sima working on how to connect a JupyterHub to this, and I believe the GUI check 'flows' much better.
Co-authored-by: Erik Sundell <[email protected]>
|
Thanks, @consideRatio! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.