Skip to content

Commit

Permalink
[pre-commit.ci] auto fixes from pre-commit.com hooks
Browse files Browse the repository at this point in the history
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Dec 19, 2023
1 parent e35112d commit 93b7555
Showing 1 changed file with 16 additions and 19 deletions.
35 changes: 16 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ The documentation should help configure the BinderHub service to:
```

This should forward requests on port 8585 on your localhost, to the binder service running inside the pod. So if you go
to [localhost:8585](http://localhost:8585), you should see a binder styled page that says 404. If you do, *success!*.
to [localhost:8585](http://localhost:8585), you should see a binder styled page that says 404. If you do, _success!_.

4. Create a docker registry for binderhub to push built images to. In this tutorial, we will be using Google Artifact Registry,
but you can use anything else as well.
Expand Down Expand Up @@ -114,24 +114,21 @@ The documentation should help configure the BinderHub service to:
10. Now that we have the appropriate permissions, let's set up our configuration! Create a
new file named `binderhub-service-config.yaml` with the following contents:

```yaml
config:
BinderHub:
use_registry: true
image_prefix: <registry-path>/binder
buildPodsRegistryCredentials:
server: "https://<region>-docker.pkg.dev"
username: "_json_key"
password: |
<json-key-from-service-account>
```
where:
1. `<registry-path>` is what you copied from step 7
2. `<json-key-from-service-account>` is the JSON file you downloaded in step 9. This is
a multi-line file - either indent it correctly to match up (the `|` allows multiline strings),
or simply edit the contents to be a single line. Since it is JSON, it does not matter.
3. `<region>` is the region your artifact registry was created in.
```yaml
config:
BinderHub:
use_registry: true
image_prefix: <registry-path>/binder
buildPodsRegistryCredentials:
server: "https://<region>-docker.pkg.dev"
username: "_json_key"
password: |
<json-key-from-service-account>
```
where: 1. `<registry-path>` is what you copied from step 7 2. `<json-key-from-service-account>` is the JSON file you downloaded in step 9. This is
a multi-line file - either indent it correctly to match up (the `|` allows multiline strings),
or simply edit the contents to be a single line. Since it is JSON, it does not matter. 3. `<region>` is the region your artifact registry was created in.

11. Run a `helm upgrade` to use the new configuration you just created:

Expand Down

0 comments on commit 93b7555

Please sign in to comment.