-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide setup instructions for installing binderhub-service #72
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ef6e2ee
Provide setup instructions for installing binderhub-service
yuvipanda df34156
Add testing instructions
yuvipanda 539d663
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dc22ee0
Cleanup registry / repository confusion
yuvipanda e7ebc9a
Clarifications to the installation document
yuvipanda 51915c8
Fix wrong indent
yuvipanda 0afa27d
Fix more indents
yuvipanda 1b269d5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ae6fdab
Apply suggestions from code review
yuvipanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is acceptable as it is. An alternative test can be to do:
I think I'd favor use of
curl
as it highlights this is the role of binderhub-service now - API level access to build/push to be consumed by non-binderhub provided UI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep this one as is for now, hope that's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also spent today with Sima working on how to connect a JupyterHub to this, and I believe the GUI check 'flows' much better.