Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paramter validation checks to recursive verifier #1596

Conversation

Al-Kindi-0
Copy link
Collaborator

Closes #972

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

One thing: we should probably change the base to be some other branch as I think we closed the PR for the current target branch.

@Al-Kindi-0 Al-Kindi-0 changed the base branch from al-recursive-verifier-remove-file to next December 12, 2024 03:48
@Al-Kindi-0 Al-Kindi-0 changed the base branch from next to al-recursive-verifier-optimizations December 12, 2024 03:51
@Al-Kindi-0
Copy link
Collaborator Author

Indeed, changed it now. We can merge this first and then finally #1594 into next.

@Al-Kindi-0
Copy link
Collaborator Author

This is ready to be merged

@Al-Kindi-0 Al-Kindi-0 merged commit 411b92c into al-recursive-verifier-optimizations Dec 13, 2024
9 checks passed
@Al-Kindi-0 Al-Kindi-0 deleted the al-recursive-verifier-check-inputs branch December 13, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants