Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range checking the parameters of recursive verifier #972

Closed
Tracked by #971 ...
Al-Kindi-0 opened this issue Jun 28, 2023 · 1 comment
Closed
Tracked by #971 ...

Range checking the parameters of recursive verifier #972

Al-Kindi-0 opened this issue Jun 28, 2023 · 1 comment
Assignees
Milestone

Comments

@Al-Kindi-0
Copy link
Collaborator

Al-Kindi-0 commented Jun 28, 2023

The recursive verifier in the standard library takes as input a number of parameters and makes several assumptions on these.
For example, the number of FRI queries is a parameter that is provided via the operand stack to the verification procedure. The current implementation of the recursive verifier makes an implicit assumption that the number of such queries is less than $100$ in the global memory layout described in the constants.masm file. Currently, this assumption is not enforced and this might lead to some "buffer-overflow" issues (i.e. attacks). Thus, it seems necessary to tackle this before using the recursive verifier in a production environment.

@bobbinth
Copy link
Contributor

bobbinth commented Jan 8, 2025

Closed by #1596.

@bobbinth bobbinth closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants