Optimize computation of DEEP queries in recursive verifier #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
changed the title
plafer
approved these changes
Dec 6, 2024
Al-Kindi-0
force-pushed
the
al-recursive-verifier-optimizations
branch
2 times, most recently
from
7ae500f to
bec35e8
Compare
|
Thanks for the review! |
bobbinth
approved these changes
Dec 9, 2024
bobbinth
approved these changes
Dec 12, 2024
|
This is ready to be merged |
Al-Kindi-0
force-pushed
the
al-recursive-verifier-optimizations
branch
from
411b92c to
b3204d6
Compare
chore: update changelog chore: address feedback Signed-off-by: Al-Kindi-0 <[email protected]>
chore: changelog update chore: add back file and update it Revert "refactor: remove file" This reverts commit 384a5af.
Al-Kindi-0
force-pushed
the
al-recursive-verifier-optimizations
branch
from
8d1547c to
d586616
Compare
|
I have also included the changes from #1596 as it was the easiest way to get commits in that one signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using better stack management, optimizes the computation of the DEEP queries by about 6%. This is less than the 10% we got in the signature verifier as the VM trace is wider and hence the impact of the optimizations is smaller.