Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow membership creation/reactivation if user_group is inactive #4385

Conversation

yuenmichelle1
Copy link
Collaborator

@yuenmichelle1 yuenmichelle1 commented Sep 5, 2024

Disallow membership creation/reactivation if User Group is Inactive. Added specs for membership reactivation which can be done via POST (use case is if a user leaves a group and uses Join Link to re-join a group)

Follow up from Slack convo found here: https://zooniverse.slack.com/archives/C010QAPB67J/p1724949294205289

Part of User_Groups Functionality Coming from new Fe-Root.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@yuenmichelle1 yuenmichelle1 marked this pull request as ready for review September 5, 2024 02:33
@yuenmichelle1 yuenmichelle1 merged commit d407b22 into master Sep 6, 2024
8 checks passed
@yuenmichelle1 yuenmichelle1 deleted the user_group_disallow_membership_creation_if_group_inactive branch September 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants