Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-user: Add DeactivatedGroup component for active membership with deactivated group #6256

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

mcbouslog
Copy link
Contributor

Package

  • lib-user

Linked Issue and/or Talk Post

Describe your changes

  • adds component for active membership with deactivated group providing brief (too brief?) message and Leave Group button
  • I could not determine a way to differentiate between a user with an active membership in a deactivated group from a user with an active membership in a brand new group, so I think this is the best solution for MyGroups displays a de-activated group #6249, though open to suggestion on a different approach or scrapping this in favor or more consideration

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX?
  • What user actions should my reviewer step through to review this PR?
  • Which storybook stories should be reviewed?
  • Are there plans for follow up PR’s to further fix this bug or develop this feature?

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

>
<SpacedText uppercase={false}>
This is a deactivated group.
Please leave the group or contact the group administrator if you believe this is an error.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this message, I think it's ok, but let me know what you think.

@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 78.792% (-0.1%) from 78.887%
when pulling 7734081 on lib-user_MyGroups-bug
into ca062d9 on master.

@goplayoutside3 goplayoutside3 self-assigned this Sep 4, 2024
Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge! As noted in our Slack convo, there's discussion around whether preventing a membership from being created for a deactivated group can be handled by panoptes (zooniverse/panoptes#4385), but in the rare case where someone may end up a member of a deactivated group, this is a definite solution.

@github-actions github-actions bot added the approved This PR is approved for merging label Sep 5, 2024
@mcbouslog mcbouslog merged commit d9b78ed into master Sep 6, 2024
8 checks passed
@mcbouslog mcbouslog deleted the lib-user_MyGroups-bug branch September 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MyGroups displays a de-activated group
3 participants