fix: Add wakeup-source; to kscan nodes for ZMK_SLEEP. #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caksoylar tried so hard to save me in #1942 (comment) and I still missed this. Fixing up the in-tree boards/shields, and will broadcast more broadly on Discord and SM. |
petejohanson
added
bug
caksoylar
reviewed
Mar 29, 2024
* ZMK_SLEEP also enables PM_DEVICE, so be sure to mark kscan nodes as wakeup sources so they can wake keyboards from sleep.
petejohanson
force-pushed
the
boards-shields/fix-kscan-wakeup-source
branch
from
80b6424 to
a8a0d27
Compare
Correct. |
caksoylar
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodes as wakeup sources so they can wake keyboards from sleep.