Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix swweeep deep sleep #2

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rmuraglia
Copy link
Contributor

I noticed that my swweeep was not able to wake from deep sleep properly today, and it is because it was missing this one property.

See this announcement in the ZMK discord for context: https://discord.com/channels/719497620560543766/719544534500900886/1223354718005497988

FYI: One small regression has been reported when enabling the ZMK_SLEEP config setting now that soft-off feature has been merged. I've fixed up all the in-tree boards & shields but if you are using a custom board/shield with deep sleep, you will need to fix the definition by adding a wakeup-source; property to all your kscan nodes. See https://zmk.dev/docs/development/new-shield#shield-overlays for an example of a kscan node with this property set correctly. Apologies for any disruption this may have caused you.

@sadekbaroudi sadekbaroudi merged commit 9195794 into sadekbaroudi:main Jun 20, 2024
59 checks passed
@rmuraglia rmuraglia deleted the fix/swweeep-deep-sleep branch June 21, 2024 02:06
sadekbaroudi added a commit that referenced this pull request Jun 21, 2024
…ollow up on issue #2 from github, see issue description for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants