Retire the unreachable seismic-moment and earthquake-profile modules - #1045
Merged
2 commits merged intoAug 20, 2026
Merged
Conversation
Ten src/lib modules and their ten unit tests, unreachable from the app bundle since they were written (Jul 13 - 27). They form one closed subtree: seismicMoment is imported only by five of them, and nothing outside the group imports any of them except their own tests. seismicMoment.ts and seismicMomentScaleBasis.ts are kept: the latter is 8 days old and still imports the former. Two wired modules carried doc-comment cross-references to seismicDepthProfile.ts; those clauses are dropped so no comment points at a deleted file. The quantile method they described (R-7 / NumPy-default) is still named in place. No behaviour change: none of these modules reach the bundle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this removes
Ten
src/libmodules and their ten unit tests. Every one of them has beenunreachable from the app bundle since the week it was written (Jul 13 – 27,
2026) — confirmed by
node scripts/walk-wired.mjs, not by a stale list.They form one closed subtree:
seismicMoment.tsis imported by five of theseismicMoment*modules, and nothing outside the group imports any of themexcept their own
.test.tsfiles.Deleted modules (git history preserves them — resurrect deliberately)
seismicDepthProfile.tsseismicDispersion.tsseismicIntereventTime.tsseismicMagnitudeProfile.tsseismicMomentByDepth.tsseismicMomentConcentration.tsseismicMomentDepthCentroid.tsseismicMomentRate.tsmagnitudeFrequency.tsearthquakeTimeline.tsKept deliberately
seismicMomentScaleBasis.ts— 8 days old, inside the 14-day protectionwindow.
seismicMoment.ts— still imported byseismicMomentScaleBasis.ts, so itis not unreachable once that module stays.
Everything else in the geology library (
earthquakes.ts,earthquakeContext.ts,magnitudeScale.ts,seismicFixedDepth.ts,seismicNetworkGeometry.ts,volcanoElevationProfile.ts, …) is untouched.Deletion criteria, all satisfied
resolved, not name-grepped).
percentile, SPI, seasonal-baseline, or record-margin module is in this set.
The two source edits
phenologyLevelProfile.tsandvolcanoElevationProfile.tseach carried adoc-comment cross-reference to
seismicDepthProfile.ts. Those clauses aredropped so no comment points at a deleted file; the quantile method they were
describing (R-7 / NumPy-default) is still named in place, and one redundant
"it parallels …" sentence goes with them. No scientific claim, citation,
threshold, or math is altered anywhere in this PR.
Line deltas
src/lib: 276 → 266 modules; the walk now reports 154 wired, 112unreachable.
Gates
npx tsc --noEmitclean ·npm test289 files / 4,502 tests green ·npx prettier --writeon both touched files (unchanged) ·npm run buildeverychunk
ok.Visible: none — dead code removal. The two edits are inside
/** */blocks;no rendered string, panel, or export changes.
🤖 Generated with Claude Code