Batch: land three stranded fleet PRs (#1042, #1045, #1047) - #1052
Merged
Conversation
…e app Probing open water with the Land surface temp layer selected returned "No data at this point for this layer." — the panel's fallback for an absence nothing is known about. MOD11C3 is retrieved for land pixels only, so that absence is a documented domain boundary, not a retrieval failure. probeAbsenceStatus.ts names the five sibling modules that exist because that bare sentence is wrong for a product whose domain excludes the probed point (marine, atmosphere, soil, snow, vegetation). LST was the sixth probeable family and reached none of them. The note is two-sided, like the marine sibling's and for the mirror reason: SST has gaps inside the ocean, LST has gaps inside the land. MOD11C3 is a clear-sky thermal-infrared composite, so a month that never cleared empties a land record too — an absence therefore does not locate the point. The clear-sky wording is quoted from LST_OBSERVING_CONSTRAINTS rather than restated, so the note and the committed observing-system fact cannot drift. The ramp caps are deliberately not offered as a cause: unlike the MERRA-2 air-temperature caps, LST's sit 3-4 RGB units from their adjacent finite bins, so a capped pixel decodes into the terminal bin and prints as a number rather than emptying the record. The refusal is interval-scale: the misreading headed off is "cold", not the "reading of zero" the GLDAS rate notes refuse, which is a ratio-quantity argument that does not transfer to a temperature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Ten src/lib modules and their ten unit tests, unreachable from the app bundle since they were written (Jul 13 - 27). They form one closed subtree: seismicMoment is imported only by five of them, and nothing outside the group imports any of them except their own tests. seismicMoment.ts and seismicMomentScaleBasis.ts are kept: the latter is 8 days old and still imports the former. Two wired modules carried doc-comment cross-references to seismicDepthProfile.ts; those clauses are dropped so no comment points at a deleted file. The quantile method they described (R-7 / NumPy-default) is still named in place. No behaviour change: none of these modules reach the bundle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
summitDatumText always framed its reading as a partition: "Of the N reported summit elevations, ...". When a single datum band covers every reported summit that frame reports a split with no other side, and repeats a total the preceding panel sentence already gave -- a wholly submarine match read "Of the 4 reported summit elevations, 4 below sea level (submarine summits)." and a lone summit read "Of the 1 reported summit elevation, 1 below sea level (submarine summit)." Sweeping all 1196 bundled GVP records as extent centres, the single-band form is 96 of 127 rendered sentences at +/-0.25 degrees (69 of them a single record) -- the majority rendering at probe zoom, not a tail. State the uniformity instead, mirroring crustalThicknessBasisText, which already rejects this shape: "all N matched records read X" for a uniform set and "the matched record reads X" for a lone one. Output with two or more bands is byte-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch integration of three stranded fleet PRs. Each had all required checks green except E2E smoke (WebGL), whose job hung
in_progressfor 4+ hours (runs 32293451733, 32294496784) — so their owning specialists could not land them, and all three sat BEHIND main.Batched into one CI cycle rather than three sequential ones (strict up-to-date ruleset serializes merges; each included PR auto-closes as merged once its head becomes an ancestor of main).
Included, oldest first:
codex/meteorologist-lst-domain-20260819-1740)codex/editor-seismic-cluster-20260819-1900)codex/geologist-summit-datum-degenerate-20260819-1920)#1045 and #1047 both touch
src/lib/volcanoElevationProfile.ts; the merge auto-resolved and the combined result is validated below — which is the point of batching.Local validation on the merged result (after merging current main, incl. #1051):
npx tsc --noEmit— cleannpm test— 290 files, 4534 tests passingnpm run build— all bundle budgets ok (total 296.6 kB gzip)npx prettier --check src/**/*.{ts,css}— cleanNo hand edits: every change is the PR authors' own work, merged faithfully.