Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert command types to dictionaries #636

Merged
merged 29 commits into from
Jul 23, 2024
Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 22, 2024

I've converted the types of every command schema for EZSP v5-v14 from a tuple of types to a dict of types. Only EZSPv4 is left. There is currently a compatibility shim to handle tuple schemas but it will be removed once v4 is finished.

This really helps with log file and code readability. Future command sending syntax will allow mixing and matching args and kwargs but bellows will migrate to kwarg-only syntax.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.13%. Comparing base (64ba03d) to head (16f0e41).

Files Patch % Lines
bellows/ezsp/protocol.py 92.30% 1 Missing ⚠️
bellows/zigbee/application.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #636      +/-   ##
==========================================
- Coverage   99.15%   99.13%   -0.03%     
==========================================
  Files          50       50              
  Lines        3447     3456       +9     
==========================================
+ Hits         3418     3426       +8     
- Misses         29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly marked this pull request as ready for review July 22, 2024 23:21
@puddly puddly merged commit 8eb257d into zigpy:dev Jul 23, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant