Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setPreinstalledCbkeData283k1 does not work #627

Closed
kazkansouh opened this issue Jun 7, 2024 · 2 comments
Closed

setPreinstalledCbkeData283k1 does not work #627

kazkansouh opened this issue Jun 7, 2024 · 2 comments

Comments

@kazkansouh
Copy link

Hello, thanks for making such a nice project 👏

I was playing around with the project while trying to set CBKE 283k1 data over EZSP and noticed the below call would fail with EmberStatus.INVALID_CALL: 112.

"setPreinstalledCbkeData283k1": (
0x00ED,
(
t.EmberPublicKey283k1Data,
t.EmberCertificate283k1Data,
t.EmberPrivateKey283k1Data,
),
(t.EmberStatus,),
),

After some searching, came across the following page in Silabs community forum: https://community.silabs.com/s/article/the-difference-when-setting-the-device-s-ca-public-key-and-283k1-curve-ca-public

Once updating this definition as below I was able to use the setValue and savePreinstalledCbkeData283k1 calls as outlined in the above link to set the CBKE data (and verified by joining it to a coordinator which required CBKE).

    "savePreinstalledCbkeData283k1": (
        0x00ED,
        (),
        (t.EmberStatus,),
    ),

I am happy to raise a PR to make this change if it would be useful?

@puddly
Copy link
Contributor

puddly commented Jun 7, 2024

Of course! I don't think I've ever used the ECC features of EmberZNet so this part of the command set exists untested. If you find any mistakes, please feel free to make a PR, it would be much appreciated.

@puddly
Copy link
Contributor

puddly commented Jul 23, 2024

This was fixed (by accident) in #636, I noticed the SDK source differed for this command.

@puddly puddly closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants