Adding game's store logic in JS #44
Conversation
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
@lorenzomiro could you maybe add the interaction to map_city instead of map_start?
In map_city, we already have set up two potential buildings with enter map tags where one of them could be a store.
Hava a look at additional map infos where you can see the tag name of the buildings which you can use in your onCollide method.
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Pull request updated with "Updated with map_city interactions moved out from map_start" |
|
See recent push with requested changes |
src/interactions/map_arcade/index.js
Outdated
There was a problem hiding this comment.
please move your additions to map_city interactions
There was a problem hiding this comment.
Revert the changes of this file. Otherwise it is not possible to go into the arcade anymore
| @@ -0,0 +1,31 @@ | |||
| import { displayDialogue } from '../../utils'; | |||
| import { sampleStoreInteraction, sampleArcadeInteraction } from './enterMapArcade.interactions'; | |||
There was a problem hiding this comment.
move your code from enterMapArcade.interactions to this file because of my comment to revert the enterMapArcade.interactions.js file
| player.onCollide('enter_map_arcade', () => { | ||
| player.isInDialog = true; | ||
| displayDialogue(sampleStoreInteraction(), () => { | ||
| player.isInDialog = false; | ||
| }); | ||
| //if user runs into the house, show them the house |
There was a problem hiding this comment.
pleaseo remove this code because there is already a enter_map_arcade interaction. otherwise it is not possible anymore to go into the arcade
| /*displayDialogue(sampleTinyHouseInteraction(), () => { //sampleTinyHouseInteraction needs building | ||
| player.isInDialog = false; | ||
| });*/ |
There was a problem hiding this comment.
ther is already the building here. You made it already right. Just add the sampleTinyHouseInteraction function and we are good to go
There was a problem hiding this comment.
please remove this file because we have it in interactions/map_city in your PR
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
1 similar comment
|
|
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @lorenzomiro, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
@lorenzomiro closed due to inactivity. Feel free to reopen the Pr or to create a new one. There were a lot of changes happening. |
I was thinking that this game would need some logic for a store that would be used to buy and sell items. This is a sample interaction that I made to get that started.