Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce LookupRangeCheckConfigs for each Sinsemilla advice column #133

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Introduce LookupRangeCheckConfigs for each Sinsemilla advice column #133

merged 5 commits into from
Jun 29, 2021

Commits on Jun 25, 2021

  1. Adjustments to APIs in sinsemilla::chip and sinsemilla::message.

    @therealyingtong
    therealyingtong committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6fdee71 View commit details
    Browse the repository at this point in the history

  2. Move witness_message() and witness_message_piece_bitstring() to gadge… 

    …t level

These instructions were not making any assignments; instead, they
were calling through to witness_message_piece_field().

This PR also renames the witness_message_piece_field() instruction
to witness_message_piece().
    @therealyingtong
    therealyingtong committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    bdcdb8a View commit details
    Browse the repository at this point in the history

  3. Configure each Sinsemilla advice column for use with a K-bit lookup. 

    Inputs to Sinsemilla often need to be decomposed and range-constrained.
    @therealyingtong
    therealyingtong committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2ec3094 View commit details
    Browse the repository at this point in the history

  4. sinsemilla::tests: Use separate constants columns for chips. 

    To be replaced by the public inputs API.
    @therealyingtong
    therealyingtong committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    9b47bd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Cleanups and minor refactors. 

    Co-authored-by: Jack Grigg <[email protected]>
    @therealyingtong @str4d
    therealyingtong and str4d committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    12cef17 View commit details
    Browse the repository at this point in the history