Introduce LookupRangeCheckConfigs for each Sinsemilla advice column
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
therealyingtong
force-pushed
the
patch-sinsemilla
branch
from
c9d34c7
to
5fbc14e
Compare
therealyingtong
force-pushed
the
patch-lookup-range-check
branch
from
6450edf
to
c43c91b
Compare
…t level These instructions were not making any assignments; instead, they were calling through to witness_message_piece_field(). This PR also renames the witness_message_piece_field() instruction to witness_message_piece().
Inputs to Sinsemilla often need to be decomposed and range-constrained.
To be replaced by the public inputs API.
therealyingtong
force-pushed
the
patch-sinsemilla
branch
from
5fbc14e
to
9b47bd0
Compare
str4d
approved these changes
Jun 28, 2021
|
|
||
| impl SinsemillaConfig { | ||
| pub fn advices(&self) -> [Column<Advice>; 5] { | ||
| [self.bits, self.lambda_1, self.lambda_2, self.x_a, self.x_p] |
There was a problem hiding this comment.
Rebase mis-merge; this is altered and documented in ff63747 (an unrelated commit). Move those changes into this PR.
There was a problem hiding this comment.
I actually don't think the advices() method is needed anymore. It was only being used to construct lookup_configs, which have now been made native to the SinsemillaConfig.
The advices() method is now only used to construct the CondSwapConfig, so I've moved it into the MerkleChip PR (#98).
Co-authored-by: Jack Grigg <[email protected]>
str4d
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #132.
Inputs to Sinsemilla are commonly decomposed into subpieces and packed into field elements. These subpieces have to be range-checked. This PR includes a
LookupRangeCheckConfigfor each Sinsemilla advice column, to enable subpieces to be looked up in any advice column.This PR also moves certain APIs from the instruction level to the gadget level.