Auto rechunk to enable blockwise reduction #380
Draft
+67
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
auto-blockwise-rechunk
branch
5 times, most recently
from
bcae992 to
0c0b0e5
Compare
dcherian
force-pushed
the
auto-blockwise-rechunk
branch
4 times, most recently
from
f0af7ee to
20e6ed8
Compare
Done when 1. `method` is None 2. Grouping and reducing by a 1D array We gate this on fractional change in number of chunks and change in size of largest chunk. Closes #359
dcherian
force-pushed
the
auto-blockwise-rechunk
branch
from
20e6ed8 to
d9a7ab5
Compare
dcherian
commented
Jun 17, 2025
| new_input_chunks = chunks | ||
|
|
||
| # FIXME: this should be unnecessary? | ||
| labels = factorize_((labels,), axes=())[0] |
There was a problem hiding this comment.
TODO: get rid of this line
dcherian
commented
Jun 17, 2025
| @@ -119,6 +119,15 @@ | |||
| # _simple_combine. | |||
| DUMMY_AXIS = -2 | |||
|
|
|||
| # Thresholds below which we will automatically rechunk to blockwise if it makes sense | |||
| # 1. Fractional change in number of chunks after rechunking | |||
| BLOCKWISE_RECHUNK_NUM_CHUNKS_THRESHOLD = 0.25 | |||
There was a problem hiding this comment.
TODO: these should probably be in some kind of "options" context manager
dcherian
commented
Jun 17, 2025
| if ascending: | ||
| return bool((arr[:-1] <= arr[1:]).all()) | ||
| else: | ||
| return bool((arr[:-1] >= arr[1:]).all()) |
There was a problem hiding this comment.
should add a test for descending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done when
methodis Nonebyis sorted.bytooWe gate this on fractional change in number of chunks and change in size of largest chunk.
Closes #359