This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Core components list handling fixes #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 13, 2019 13:20
…ndle the List Component
| public class DefaultMultifield implements Multifield { | ||
|
|
||
| @FindBy(css = "button.coral3-Button.coral3-Button--secondary") | ||
| @FindBy(css = "* button[coral-multifield-add]") |
There was a problem hiding this comment.
Why a star selector here?
| By.cssSelector(".foundation-picker-buttonlist.coral3-Overlay.is-open"))); | ||
| label.get(0).click(); | ||
| bobcatWait.until(elementToBeClickable(firstResult)); | ||
| firstResult.click(); |
There was a problem hiding this comment.
You can chain these two.
mkrzyzanowski
suggested changes
Sep 19, 2019
| @PageObject(css = Locators.AUTOCOMPLETE_CSS) | ||
| public class DefaultTagBrowser implements TagBrowser { | ||
|
|
||
| @FindBy(className = "coral3-Textfield") |
There was a problem hiding this comment.
Use the css locator strategy here - it will be more consistent
|
|
||
| @Override | ||
| public void setValue(Object value) { | ||
| List<String> tags = new ArrayList<>( |
There was a problem hiding this comment.
Wrap in new ArrayList<>() is unnecessary here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Bobcat to handle the List from Core Components and is required for it's BB tests to work wttech/bobcat-aem-tests#7 for #373
Motivation and Context
Types of changes
Checklist: