This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Core components list tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 8, 2019 11:31
Refactor Title tests to not rely on useless interface
Finish tests for List Item Settings
Note: the tests work now only with a custom BB build and the list item pages creation is still commented out due to faulty xml parsing in BB
Finish all List Component tests
8 tasks
mkrzyzanowski
suggested changes
Sep 19, 2019
aem65/build.gradle
Outdated
| @@ -17,7 +17,7 @@ apply plugin: 'io.qameta.allure' | |||
|
|
|||
| sourceCompatibility = 1.8 | |||
|
|
|||
| def bobcatVersion = System.getProperty("bobcat.version", "2.1.0") | |||
| def bobcatVersion = System.getProperty("bobcat.version", "2.1.1-SNAPSHOT") | |||
There was a problem hiding this comment.
For development purposes, set the variable via the command line - this way users can clone this repo and run tests with the latest Bobcat on their own.
| import com.cognifide.qa.bb.qualifier.PageObject; | ||
| import com.google.inject.Inject; | ||
|
|
||
| @PageObject(css = ".cmp-list") |
There was a problem hiding this comment.
Hm, maybe a link to docs from the AEM Core components repo in the JavaDoc?
| linkElements) { | ||
| links.add(element.getAttribute(Attributes.HREF)); | ||
| } | ||
| return links; |
There was a problem hiding this comment.
You can also do this with Stream API :):
linkElements.stream().map(element -> element.getAttribute(Attributes.HREF)).collect(toList());
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the List Component for wttech/bobcat#373 - requires wttech/bobcat#381 to work