Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 Refactor RC #327

Merged
merged 218 commits into from
Oct 28, 2024
Merged

V1 Refactor RC #327

merged 218 commits into from
Oct 28, 2024

Commits on Apr 10, 2023

  1. intitial separation

    e-lo committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    4913036 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. initial refactor

    e-lo committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    247d90f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Refactor selection, segments, apply

    WIP for showing
    e-lo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8eb9cc0 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Factored out major parts or RoadwayNetwork to other classes

    - removed project card.py
    - refactored selection, graph, subnet, segment from roadway network
    - refactored project changes apply from roadway network
    - refactored shapes, links and nodes specs from roadway network
    e-lo committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6351925 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34c0ddb View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. debugging

    e-lo committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    a1ca5c9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. update project card formats

    + varia bug fixes
    e-lo committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5208330 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    396676b View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. selections tests passing

    e-lo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4f943b1 View commit details
    Browse the repository at this point in the history
  2. test_properties passs

    e-lo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6402ef4 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Configuration menu
    Copy the full SHA
    f0310d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Format updates, linting

    e-lo committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    58d27f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Refactor transit selection

    transit selection tests passing
    e-lo committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    80cad3c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. transit tests working

    + linting
    e-lo committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3ffc565 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. refactor transit project application

    - generalize transit property change projects to be any attribute in table
    e-lo committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ff21855 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    fdfa5b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. rename to timespans

    - update required link attr
    - pep8
    - refactor time --> timespan
    e-lo committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    7ef4580 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    c4048fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b55414b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50652d6 View commit details
    Browse the repository at this point in the history
  4. Remove LocationReferences / Speed up I/O and allow other serializatio…

    …n formats
    
    - Remove LocationReferences from required part of schema that we fill in. Jump straight to geometries.
    - Make link geometry creation a vector operation —> speeds up significantly 30-100 times as fast
    - Added - Accessor for link true-shapes
    - Add clipping functionality for roadway and transit
    e-lo committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    dbcddb1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e70b32a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    867753d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Improved small-network example

    Now has enough nodes and transit to test most functionality - quickly and more importantly - easy to debug!
    
    Fixes #343
    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9318a06 View commit details
    Browse the repository at this point in the history
  2. Implement roadway and transit data models.

    Create base set of types and classes implemented in pandera and pydantic to efficiently validate GTFS and network data and foreign keys.
    
    Fixes #266, #344 #123, and #345
    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    aa18ffe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    311ae50 View commit details
    Browse the repository at this point in the history
  4. Update setup scripts/configs

    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d7a3c51 View commit details
    Browse the repository at this point in the history
  5. Add network format conversions.

    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    30072e0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fc52ba8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6131994 View commit details
    Browse the repository at this point in the history
  8. Draft an overview of v1 release features

    WIP...
    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    166bac7 View commit details
    Browse the repository at this point in the history
  9. Fix bug in selection dictionary

    Now that selection dictionary is a data model and will default to none - need to not "select none"!
    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    61748ee View commit details
    Browse the repository at this point in the history
  10. bug fixes for transit data models

    All transit tests passing!
    e-lo committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cb1d0d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. remove cruft we aren't using

    e-lo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    24eac37 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0da4f32 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b530e20 View commit details
    Browse the repository at this point in the history
  4. update API for scripts

    e-lo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9971f51 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d470cc0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    92eb4f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    a208654 View commit details
    Browse the repository at this point in the history
  2. small renaming

    e-lo committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    02a3cea View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    1bf40ef View commit details
    Browse the repository at this point in the history
  2. Update script calls

    e-lo committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    8a24f96 View commit details
    Browse the repository at this point in the history
  3. Pull out 'scoped', improve performance, fix bugs, add docs

    - Pull out "scoped" properties as separate column in data model
    - Fix managed lanes algorithms
    - Defrag / rearrange df accessors, filters and make copy and filtering views consistent terminology
    - Fix numerous bugs in code and tests to get (most) tests passing
    - Add numerous doc strings to functions and modules.
    - Update import statements to be more efficient/limit circular refs
    - Add tests for almost all utilities.
    - Add tests for scoping calculations
    - Significant performance improvements in model network/access egress link creation, and scoped property setting and lookups.
    e-lo committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    036efc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Fix one-to-many update function

    - add tests for it
    - update to use indices propertly for one-to-many property updates
    e-lo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bdef653 View commit details
    Browse the repository at this point in the history
  2. Add feed path to feed obj

    e-lo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2e376ed View commit details
    Browse the repository at this point in the history
  3. Fix typo in project card

    e-lo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    82d2bca View commit details
    Browse the repository at this point in the history
  4. Fix selection type lookups

    e-lo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c7a60f7 View commit details
    Browse the repository at this point in the history
  5. Update ml_access/egress_point to be bool rather than list of nodes

    Very difficult to deal with lists within a record and also inefficient.
    e-lo committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e39ad3e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    4ab5530 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aaf0c3d View commit details
    Browse the repository at this point in the history
  3. update requirements to install projectcard from github

    Also add metadata
    e-lo committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f003b06 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    aa003f0 View commit details
    Browse the repository at this point in the history
  2. main not master (doh)

    e-lo committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0a1c094 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. clean up docs / bump version

    e-lo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    beef6cf View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    c705ea3 View commit details
    Browse the repository at this point in the history
  2. Update pytest and gitignore

    e-lo committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    645b421 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0197a39 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Fix FK checking

    - Don't check pk if fk field isn't there
    - Don't check pk if fk is NaN
    - Check pk/fk on validated table
    - Fix reversed function call
    - Added some docs to make it more obvious which is fk and which is pk
    e-lo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8f3beef View commit details
    Browse the repository at this point in the history
  2. Fix pyproject to explictly state package name

    Also updated test to be more rigorous/resilient
    e-lo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6193bf5 View commit details
    Browse the repository at this point in the history
  3. Linting!

    e-lo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fa18f1a View commit details
    Browse the repository at this point in the history
  4. add framework for adding transit route

    - /transit/projects/add_route.py
    - test_transit_add_route.py
    e-lo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0377428 View commit details
    Browse the repository at this point in the history
  5. add import statement...

    e-lo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    40e9fc9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. pin Mike for rebuild flag

    e-lo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3d1c1e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee41c84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    745cd89 View commit details
    Browse the repository at this point in the history
  4. bump version

    to alpha...
    e-lo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    986d565 View commit details
    Browse the repository at this point in the history
  5. lint

    e-lo committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bb379b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Fix timespan ---> timespans for transit trip selection

    Per error IDed in #355
    e-lo committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    eae3954 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6445495 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f3445cb View commit details
    Browse the repository at this point in the history
  4. fix deep copy call

    e-lo committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    48fd539 View commit details
    Browse the repository at this point in the history
  5. fix: subprojects is _subprojects

    e-lo committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9049a21 View commit details
    Browse the repository at this point in the history
  6. Fix: process multiple timespans, not single timespan

    - also fix so that time is from "today()" instead of 1900 by default which is consistent with data model.
    e-lo committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    10f2dd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    f55fcf0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3916b41 View commit details
    Browse the repository at this point in the history
  3. Add geographic-filter-on-read capability; start chunking

    Chunking doesn't yet work...
    e-lo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6933c75 View commit details
    Browse the repository at this point in the history
  4. lint...

    e-lo committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    aed82ec View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Fill empty "name" values with "unknown"

    Fixes #358
    e-lo committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6828330 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. changes copy to deepcopy()

    - changes copy to deepcopy() to make sure geodataframes CRS are copied
    - update linting settings
    e-lo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    60d7ab9 View commit details
    Browse the repository at this point in the history
  2. Generates link and node ids based on available range rather than a sc…

    …alar.
    
    Fixes #361  and associated tests
    Generalizes copy and offset links from `modelroadway.py` --> `links/create.py`
    Checks and generates access/egress links if there aren't any created when a managed lane is added but no explicit access or egress is set in the project card.
    e-lo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e0427f5 View commit details
    Browse the repository at this point in the history
  3. Add conversion of complex link properties on I/O

    - Will sniff and convert from v0 to v1 on read
    - Will write to v0 if flagged on write using `convert_complex_link_properties_to_single_field`
    - Should fix #359
    TODO: needs tests
    e-lo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    55c3350 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Document network wrangler network format. (#329)

    * Add network format and methods docs
    e-lo authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    777f9e1 View commit details
    Browse the repository at this point in the history
  2. small bug fix - erroneous copy

    e-lo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    1f8e263 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0e7ec3 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    754b966 View commit details
    Browse the repository at this point in the history
  2. Default to "any" mode when project is link deletion

    Fixes #364
    Lint
    e-lo committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    dde7540 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Add validation scripts / modernize bin dir

    - consolidate all scripts in network_wrangler/bin directory
    - list scripts in pyproject.toml for installation
    - normalize the #! of all scripts
    - add validation scripts for networks and associated helper functions fixes #285
    e-lo committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fc35831 View commit details
    Browse the repository at this point in the history
  2. add docs on validating networks

    e-lo committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6f82ec2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c0b4581 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f21f6fb View commit details
    Browse the repository at this point in the history
  5. Format installation tips

    Fixes rest of #175
    e-lo committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7b8d6f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    091ef2e View commit details
    Browse the repository at this point in the history
  7. Update gtfs data model "stop_id" is a valid "model_node_id" (#365)

    Set stop_id as a valid model_node_id
    
    - Remove concept of separate stop_id but store gtfs stop_id as gtfs_stop_id.
    - Fixes #354
    
    I'm going to go ahead and merge this so I can proceed with other items.
    e-lo authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3b922b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Write out scoped items from object not dict

    Cherrypick of : 6aad831 but with catch for DEFAULT_CATEGORY
    e-lo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    71199d2 View commit details
    Browse the repository at this point in the history
  2. lint

    e-lo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    49ddfe3 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Enforce GeoSeries for ML_Geometry

    Should address issue in #367
    e-lo committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3b68343 View commit details
    Browse the repository at this point in the history
  2. Fix timespan queries; Add applied project to roadway and transit feat…

    …ures (#369)
    
    * Fix small bug in roadway deletion: modes not mode.
    * Fix #282 Log applied project name as feature-level variable
    - updates transit and roadway data models to add `projects` as string
    - updates add and change projects to append project name to `projects`
    - tests that it is appropriately logged
    * Fix #368 resiliently query to update headway when there are multiple entries per trip_id
    - Separately query timespans to enforce "or" logic 
    - Separate querying of frequencies from querying of stoptimes so frequencies can return more than one entry
    - Separate GTFS and Wrangler Frequencies and Stoptime schemas for times: string in HH:MM --> datetime object
    - Add parser to parse strings to datetimes upon conversion to Wrangler table models: note that it will not correctly do H>24 :-( 
    - Fix parsing of times to have consistent days
    - Make default arrival/departure and start_stop related to DEFAULT_TIMESPAN
    - Allow for single-digit hours
    - enforce str schema for time strings
    - raise TableValidationErrors for ValueError and TypeErrors
    * Other:
    - reduce some debugging noise
    e-lo authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b7b3b91 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    7f1b2e8 View commit details
    Browse the repository at this point in the history
  2. change default for clean_shapes/routes to False

    - fix bug in test
    e-lo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f3c0d21 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Refactor add_route()

    - make lots of smaller functions to make changing it easier and reduce giant nested loops
    - reduce (some) of the iterative df concats for single records
    - FEAT: now will add any arbitrary values for routes.txt, trips.txt and stop_times.txt that aren't reserved words
    e-lo committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fd6d352 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Debugged adding transit - passing test and ready to be tested more.

    - add default service_id
    - update validation errors that are raised to TableValidationError
    - add NodeNotFoundError
    - debug node_coords()
    e-lo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    62c27f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8488f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6d0aa1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7eb3789 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix: allow timespans over midnight (#377)

    * add functionality to handle time periods crossing midnight
    - assume if timespan end time < timespan start time that it is crossing midnight.
    
    Still WIP to get timestamps > 24H to work because pandera parser is pre-parsing as timestamps.
    e-lo authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    67dc0ae View commit details
    Browse the repository at this point in the history
  2. Update pandera requirement > 0.19

    Fixes #371
    e-lo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    beb00fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    063d3ab View commit details
    Browse the repository at this point in the history
  4. Add pydantic only (no pandera) validation wrapper validate_call_pyd

    - Only do rigorous pandera validation on main I/O
    - Got test_change_multiple_properties_multiple_links() down from 8 sec to 1.8 seconds
    
    TODO: transit
    e-lo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ae24687 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    6c0af39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    346067d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49f207c View commit details
    Browse the repository at this point in the history
  4. Make error for missing nodes for new links more obvious

    and fix the project card that has missing nodes
    e-lo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f9cddf3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4fdd29b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5516885 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add benchmark tests and post PR comments c.t. base

    - lints
    e-lo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ab302b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    889da7e View commit details
    Browse the repository at this point in the history
  3. add ability to have project be a prereq for multiple projects

    Fix #341 for this branch with fix applied by @i-am-sijia in main
    e-lo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5bf40e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    e1cd550 View commit details
    Browse the repository at this point in the history
  2. update docstring

    yueshuaing committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    17a6563 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df1c09b View commit details
    Browse the repository at this point in the history
  4. update docstring

    yueshuaing committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    346cad0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9a137ca View commit details
    Browse the repository at this point in the history
  6. Merge pull request #374 from wsp-sag/add-delete-transit-projects

    Add change types: transit deletion and transit addition
    yueshuaing authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f15e41b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b29d84b View commit details
    Browse the repository at this point in the history
  8. Revert "Merge branch 'selection-refactor' into address-performance"

    This reverts commit b29d84b, reversing
    changes made to 889da7e.
    yueshuaing committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    de7a7f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    9f6b176 View commit details
    Browse the repository at this point in the history
  2. remove duplicate parameter

    yueshuaing committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a5af824 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #378 from wsp-sag/address-performance

    Instrument + address performance
    yueshuaing authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8676793 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48f8449 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add Configurability, Scenario Config, and Scenario Serialization (#379)

    * add ability to specify scalar or range for ML id generation
    
    * Add Configurability and scenario serialization
    
    - Add wrangler configs including scalar model roadway numbering options (#361)
    - Add scenario configuration handling
    - Add stricter mypy testing and resolve most typing issues
    - Fix a handful of example project cards that hadn't been synced with the network.
    - Add scenario serialization capability with scenario.write() (#376)
    
    * resolve mypy complaints
    e-lo authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8671afa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6e4f13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7326c6 View commit details
    Browse the repository at this point in the history
  4. Fix bug from merge

    When we did a merge from PRs on performance + scenario the copying of the attrs got lost in the validate df function - oops. Fixing that here.
    e-lo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5bc9440 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    466c6e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. add load_scenario()

    - resolve a handful of bugs from all the merges with df.attrs
    - add example documentation for scenario loading/writing
    - work on yaml loading so it will load python objects
    - add a test for writing and loading scenario files
    - align on "file_format" (previously used both file_format and suffix)
    e-lo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    57458b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c38fa8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e8fb931 View commit details
    Browse the repository at this point in the history
  4. Clean up tests from merging errors.

    - All tests other than those covered in #382
    e-lo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    eb7f43c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    376035c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f4db70 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    131e2ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9843c3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fed524b View commit details
    Browse the repository at this point in the history
  4. quick fix for metcouncil pre-release

    need to revisit it later to fix them properly
    yueshuaing committed Sep 30, 2024
    1 Configuration menu
    Copy the full SHA
    aec6669 View commit details
    Browse the repository at this point in the history
  5. timespan is a tuple, not string

    Removed bug in strip().split from timespan
    e-lo committed Sep 30, 2024
    2 Configuration menu
    Copy the full SHA
    9d814d4 View commit details
    Browse the repository at this point in the history
  6. Implement functionality for project card to dictate how to handle sco… (

    #375)
    
    OVERWRITE_CONFLICTING_SCOPED and EXISTING_VALUE_CONFLICT_ERROR are now config parameters which can be overridden at the project-card level.
    
    * Fixes #373
    * Fixes bug for matching scopes discussed in #375
    * Incorporate three-options for existing-value-confict: error, warn, and skip rather than just error or not.
    allows to be overridden by project card
    e-lo authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ade3130 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    91dad74 View commit details
    Browse the repository at this point in the history
  8. Update contribution guidelines and github issue and pull request temp…

    …lates.
    
    - update contribution guidelines
    - add chores template
    - update language to be consistent with contributation guidelines
    e-lo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b11767a View commit details
    Browse the repository at this point in the history
  9. Update Design and Installation documentation

    - Design now includes up-to-date descriptions and adds in information about running scenarios, scoped elements, etc.
    - Installation instructions streamlined to not include development instructions (moved to CONTRIBUTING.md)
    - Mermaid refs fixed
    - Add some docstring attribute details
    e-lo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7356a70 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    da04aef View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2909a6e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d1eacb6 View commit details
    Browse the repository at this point in the history
  13. Remove docker stuffs

    Unecessary.
    e-lo committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8d2b894 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. add tested environment

    e-lo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9e4ee9b View commit details
    Browse the repository at this point in the history
  2. use concat_with_attr in transit route addition

    move adding extra route attributes to downstream,
    create a single "addition" df for each table-type
    yueshuaing committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    466f3f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ace4c7c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    e6319f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a625310 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fbdc24 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    adfe7df View commit details
    Browse the repository at this point in the history
  2. Use include-markdown plugin

    - Deprecate our own macros now that a real plugin is available.
    e-lo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6ed3241 View commit details
    Browse the repository at this point in the history
  3. Resolve stricter mypy and ruff errors.

    MyPy and Ruff had *very* lenient settings before as we were in active development. As we move towards a release, I added back most of the linting and testing and have resolved most of them in this commit.
    e-lo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    389d9aa View commit details
    Browse the repository at this point in the history
  4. Small bug fixes

    - data_to_links_df no longer takes "config" input
    - unlink() should be remove() for deleting files in test now that using pathlib
    - typo for logger inport fixed
    e-lo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d843d57 View commit details
    Browse the repository at this point in the history
  5. Typos in logging

    e-lo committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    87c0f9c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Minor fixes in tests.

    e-lo committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5d091da View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Minor bug fixes and cleanup

    - Use tests/out instead of scratch dir consistently
    - Fix typing and docs for overwrite_scoped param
    - Fix conflicts which should be a dict not a list
    - Fix issue when scoped properties are given as not grouped...need to add them as-is.
    - Fix trying to write out projects that aren't stored in scenario.
    - Fix bugs in loading scenarios related to file suffices and base scenario argument
    - Fix accidental drop of timespan from scoped variable query.
    - Lint
    e-lo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cff2287 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7d9fe2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e37049f View commit details
    Browse the repository at this point in the history
  4. ml related updates

    yueshuaing committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    87e0e5c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    067f22e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. add scenario tests

    yueshuaing committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6ee24e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Configuration menu
    Copy the full SHA
    8f29484 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e6a17a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Lint / Fix Types / Fix Requirements

    Requirements missing pre-commit and had some installed by conda that should be PIP
    e-lo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0c0d23a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80d5fe8 View commit details
    Browse the repository at this point in the history
  3. LImit validation for multiple property edits.

    Perform validation at end of multiple property edits.
    e-lo committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bcdc41c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Enhance performance of selection by dictionary.

    Speeds up explicit ID link selection for St Paul network from 0.9s to .015s
    e-lo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c630b00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bce6b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7734c6a View commit details
    Browse the repository at this point in the history
  4. update envs to include fiona

    Required for selecting geographies on input read
    e-lo committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3d922bc View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Fix scenario i/o; Shift Transit/Roadway deletion conflicts to warning

    Fixes #389  and the test that it was using
    Downgrades error to warning for deleting roadways with transit so can apply changes see discussion in #390
    Adds back all geojson files which were accidentally added to .gitignore
    Updates API for project cards to be consistent with project card v3.3.3
    Deletes extraneous file validation_failure_cases.csv
    Moves all roadway selection logic from the data models to selection classes
    Updates several notebooks with current API
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a71084f View commit details
    Browse the repository at this point in the history
  2. Bump version

    Also:
    updates python target to 3.9 from 3.8 and makes various suggested linting changes as a result
    move version to __init__ from pyproject.toml
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c98dc77 View commit details
    Browse the repository at this point in the history
  3. Actions should fail if pytest does

    - use TypeGuard from typing-extensions to maintain python 3.9 compatibility
    - add -e to make sure push.yml fails if pytest does
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    67a4ceb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b81bbe0 View commit details
    Browse the repository at this point in the history
  5. rm test dependencies

    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b0eeeb1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d38e50e View commit details
    Browse the repository at this point in the history
  7. Try using o pipefail to get workflow to fail if tests do.

    - also set geopandas>1.01 to use unary_union()
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    23ce5f7 View commit details
    Browse the repository at this point in the history
  8. fix: transit gdf creation

    - add ipywidgets as viz
    - fix error in shape links gdf creation and add tests for it
    - add handful of helper methods for stop_times
    - update ipynb for quickstart and visual checks
    - rm old project cards that don't match current network
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    807f0ea View commit details
    Browse the repository at this point in the history
  9. Make examples more concise.

    Fixes #392
    Strips non-standardized data from stpaul roadway network per clean_networks.ipynb
    e-lo committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    298395b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. cleans EOL lint from st paul net

    - removes notebook output
    e-lo committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    df1d3fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6602dd7 View commit details
    Browse the repository at this point in the history
  3. Fix example Network - add back in "ref"

    - Accidentally deleted 'ref' from st paul roadway links b/c wasn't in data model even though it is used.
    - Added to data model since it is a key OSM field as optional and updated example network to include it.
    - Updated error checking for the dict query to make sure it is explicitly telling you the field doesn't exist in the df you are querying
    e-lo committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8bed3cc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Try again to re-add link.json

    Also:
    - try to fix benchmarking/coverage reports #394
    - Fix bug in build osm roadnet.py
    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7483fd6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ee2822 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1640a8e View commit details
    Browse the repository at this point in the history
  4. try removing profiling

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    dc209ff View commit details
    Browse the repository at this point in the history
  5. try moving coverage

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    bc50f94 View commit details
    Browse the repository at this point in the history
  6. still testing pytest args

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9c90a1f View commit details
    Browse the repository at this point in the history
  7. remove all pytest config options

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8e078bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cabee68 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7a00ce5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6850aeb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a5d626a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2870cde View commit details
    Browse the repository at this point in the history
  13. add back benchmark commands

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3a185d2 View commit details
    Browse the repository at this point in the history
  14. trying to add back in profiling

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5877489 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    bb8a71d View commit details
    Browse the repository at this point in the history
  16. Order output tables based on datamodel

    Fixes #395 and tests it as well
    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    63a1963 View commit details
    Browse the repository at this point in the history
  17. Update formatting for some docs

    Also:
    - link to notebooks that have additional details/info
    - add info about using included conda env and installing optional dependencies
    - change name of quickstart to intro since it is actually fairly in depth
    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3d16af5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4626a0c View commit details
    Browse the repository at this point in the history
  19. Lint

    e-lo committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8fdf83c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Update gh workflows to update "latest" and avoid docs pull clash

    - include docs build as part of release and push to avoid a pull clash
    - update checkout/python action versions for 4 and 5
    - separate prerelease and release workflows
    - prerelease workflow pushes on any main push and wont collide with versions
    - fix typo referring to other repo
    - make pyproject.toml dependencies recursive so tests also includes docs and viz
    e-lo committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    97e223f View commit details
    Browse the repository at this point in the history
  2. Try coverage settings

    - using coverage.xml
    e-lo committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    67cb628 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    005b9af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b6e4ce View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Update issue templates. skip ci

    e-lo committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    653cad2 View commit details
    Browse the repository at this point in the history
  2. lint line endings skip-ci

    e-lo committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fd8d0ad View commit details
    Browse the repository at this point in the history