V1 Refactor RC #327

e-lo · 2023-04-13T20:51:10Z

This PR

Factors out methods from the RoadwayNetwork class in order to more easily understand and manage the combined functionality.
Adds functionality for adding and deleting transit routes
Improves speed and performance (and documents it)
Contains more rigorous type-testing and structure checking including for FKs
Provides for configurability by the user

WIP for showing

- removed project card.py - refactored selection, graph, subnet, segment from roadway network - refactored project changes apply from roadway network - refactored shapes, links and nodes specs from roadway network

+ varia bug fixes

transit selection tests passing

+ linting

- generalize transit property change projects to be any attribute in table

- update required link attr - pep8 - refactor time --> timespan

…ference IDS

…n formats - Remove LocationReferences from required part of schema that we fill in. Jump straight to geometries. - Make link geometry creation a vector operation —> speeds up significantly 30-100 times as fast - Added - Accessor for link true-shapes - Add clipping functionality for roadway and transit

Removed bug in strip().split from timespan

#375) OVERWRITE_CONFLICTING_SCOPED and EXISTING_VALUE_CONFLICT_ERROR are now config parameters which can be overridden at the project-card level. * Fixes #373 * Fixes bug for matching scopes discussed in #375 * Incorporate three-options for existing-value-confict: error, warn, and skip rather than just error or not. allows to be overridden by project card

…lates. - update contribution guidelines - add chores template - update language to be consistent with contributation guidelines

- Design now includes up-to-date descriptions and adds in information about running scenarios, scoped elements, etc. - Installation instructions streamlined to not include development instructions (moved to CONTRIBUTING.md) - Mermaid refs fixed - Add some docstring attribute details

…rk_wrangler into selection-refactor

Unecessary.

move adding extra route attributes to downstream, create a single "addition" df for each table-type

- Deprecate our own macros now that a real plugin is available.

MyPy and Ruff had *very* lenient settings before as we were in active development. As we move towards a release, I added back most of the linting and testing and have resolved most of them in this commit.

- data_to_links_df no longer takes "config" input - unlink() should be remove() for deleting files in test now that using pathlib - typo for logger inport fixed

- Use tests/out instead of scratch dir consistently - Fix typing and docs for overwrite_scoped param - Fix conflicts which should be a dict not a list - Fix issue when scoped properties are given as not grouped...need to add them as-is. - Fix trying to write out projects that aren't stored in scenario. - Fix bugs in loading scenarios related to file suffices and base scenario argument - Fix accidental drop of timespan from scoped variable query. - Lint

…update notebooks

…rk_wrangler into selection-refactor

e-lo added 3 commits April 10, 2023 16:28

intitial separation

4913036

initial refactor

247d90f

Refactor selection, segments, apply

8eb9cc0

WIP for showing

e-lo self-assigned this Apr 13, 2023

e-lo marked this pull request as draft April 13, 2023 20:52

e-lo added 20 commits April 27, 2023 15:02

Factored out major parts or RoadwayNetwork to other classes

6351925

- removed project card.py - refactored selection, graph, subnet, segment from roadway network - refactored project changes apply from roadway network - refactored shapes, links and nodes specs from roadway network

Merge branch 'develop' into selection-refactor

34c0ddb

debugging

a1ca5c9

update project card formats

5208330

+ varia bug fixes

update selection tests to have answers

396676b

selections tests passing

4f943b1

test_properties passs

6402ef4

Passing almost all roadway tests now

f0310d1

Format updates, linting

58d27f8

Refactor transit selection

80cad3c

transit selection tests passing

transit tests working

3ffc565

+ linting

refactor transit project application

ff21855

- generalize transit property change projects to be any attribute in table

Update project cards and API to be consistent with projectcard structure

fdfa5b2

rename to timespans

7ef4580

- update required link attr - pep8 - refactor time --> timespan

Add roadway network clipping feature

c4048fa

Fix roadway single node example with incorrect ..referenceID --> ..re…

b55414b

…ference IDS

Update transit timespan --> timespans per project card v1 spec

50652d6

Update notebooks and tests to use updatated API

e70b32a

Update organization of pydantic and pandera data models

867753d

yueshuaing had a problem deploying to pypi September 30, 2024 09:29 — with GitHub Actions Failure

e-lo and others added 29 commits September 30, 2024 08:32

timespan is a tuple, not string

9d814d4

Removed bug in strip().split from timespan

YAML reads timespan as string

91dad74

Update contribution guidelines and github issue and pull request temp…

b11767a

…lates. - update contribution guidelines - add chores template - update language to be consistent with contributation guidelines

Merge branch 'selection-refactor' of https://github.com/wsp-sag/netwo…

da04aef

…rk_wrangler into selection-refactor

add mermaid to mkdocs requirements

2909a6e

add mermaid to mkdocs - in pyproject.toml too!

d1eacb6

Remove docker stuffs

8d2b894

Unecessary.

add tested environment

9e4ee9b

use concat_with_attr in transit route addition

466f3f5

move adding extra route attributes to downstream, create a single "addition" df for each table-type

add test for bugs find in writing out scenario

ace4c7c

add load_scenario to __init__

e6319f5

v1_row can be a mix of dictionary and scoped link property

a625310

add a missing line back to _v1_to_v0_scoped_link_property

4fbdc24

Resolve settings to pyproject.toml; Bump requirements versions

adfe7df

Use include-markdown plugin

6ed3241

- Deprecate our own macros now that a real plugin is available.

Resolve stricter mypy and ruff errors.

389d9aa

MyPy and Ruff had *very* lenient settings before as we were in active development. As we move towards a release, I added back most of the linting and testing and have resolved most of them in this commit.

Small bug fixes

d843d57

- data_to_links_df no longer takes "config" input - unlink() should be remove() for deleting files in test now that using pathlib - typo for logger inport fixed

Typos in logging

87c0f9c

Minor fixes in tests.

5d091da

Clean up some notebooks/ fix bug in link_shapes_df

c7d9fe2

revert the quick fix in metcouncil prerelease

e37049f

ml related updates

87e0e5c

use indices to check if any missing nodes

067f22e

add scenario tests

6ee24e5

Fix bug in selecting by name; Move errors; Fix minnehaha pkwy query; …

8f29484

…update notebooks

Merge branch 'selection-refactor' of https://github.com/wsp-sag/netwo…

9e6a17a

…rk_wrangler into selection-refactor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V1 Refactor RC #327

V1 Refactor RC #327

e-lo commented Apr 13, 2023 •

edited

Loading

V1 Refactor RC #327

Are you sure you want to change the base?

V1 Refactor RC #327

Conversation

e-lo commented Apr 13, 2023 • edited Loading

e-lo commented Apr 13, 2023 •

edited

Loading