Fix admin sp creation issue #38
Merged
+51
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshanasbg
reviewed
Oct 12, 2020
| Tenant tenant = this.getTenantDomain(); | ||
| String userName = tenant.getAdminName(); | ||
| startTenantFlow(tenant.getDomain(), userName); | ||
| String userName = this.getTenantAdminName(); |
There was a problem hiding this comment.
darshanasbg
reviewed
Oct 12, 2020
| if (log.isDebugEnabled()) { | ||
| log.debug("Tenant admin name " + userName + " retrieved for tenant domain " + tenantDomain); | ||
| } | ||
| startTenantFlow(tenantDomain, userName); |
There was a problem hiding this comment.
Ideally we should improve this to use the user who add the configuration instead of using tenant admin.
There was a problem hiding this comment.
Agreed. I created an issue to track it as improvement. #39
Thumimku
force-pushed
the
admin_sp_creation
branch
from
b0cf927 to
2224356
Compare
remove_this_from_private_method remove_this_in_private_method
Thumimku
force-pushed
the
admin_sp_creation
branch
from
2224356 to
25f9a8e
Compare
darshanasbg
approved these changes
Oct 12, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose