Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote Fetch Git Integration Feature Improvement. #9503

Closed
1 of 2 tasks
Thumimku opened this issue Sep 20, 2020 · 2 comments
Closed
1 of 2 tasks

remote Fetch Git Integration Feature Improvement. #9503

Thumimku opened this issue Sep 20, 2020 · 2 comments

Comments

@Thumimku
Copy link
Contributor

Thumimku commented Sep 20, 2020

Is your feature request related to a problem? Please describe.
#8278
Regarding above issue, I am creating this issue to track the improvements.

  • Remote fetch configuration feature is only support for non super domains.

    • For Pooling action listener, it need to fetch and deploy SP artifacts from Github periodically. In order to deploy SP we need admin username.
    • Admin username is need to start tenant flow and importSPApplication method.

https://github.com/wso2-extensions/identity-fetch-remote/blob/42006ff743e6e01d9e451f7accf836901f3fa140/components/org.wso2.carbon.identity.remotefetch.core/src/main/java/org/wso2/carbon/identity/remotefetch/core/impl/deployers/config/ServiceProviderConfigDeployer.java#L75

https://github.com/wso2-extensions/identity-fetch-remote/blob/42006ff743e6e01d9e451f7accf836901f3fa140/components/org.wso2.carbon.identity.remotefetch.core/src/main/java/org/wso2/carbon/identity/remotefetch/core/impl/deployers/config/ServiceProviderConfigDeployer.java#L86

  • Tenant.getAdminName() is used here and this method will not return suitable value for super admin.

  • Implement Secure Webhook mechanism.

@Thumimku
Copy link
Contributor Author

1 st Issue was fixed in wso2-extensions/identity-fetch-remote#38

@isharak isharak added the IceBox label Nov 5, 2024
@isharak
Copy link
Member

isharak commented Nov 6, 2024

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

@isharak isharak closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants