Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up description via HTML escape #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

markpeek
Copy link

As the description is taken from the raw text of the document it can contain some HTML reserved characters. This change will escape the description string to use HTML entities instead.

This was causing an error when generating a sphinx EPUB document.

As the description is taken from the raw text of the document it
can contain some HTML reserved characters. This change will escape
the description string to use HTML entities instead.
@TheTripleV
Copy link
Member

I wonder what users of og:desc do. Like how slack and discord embeds display the escaped version. It should be fine but just wanna check.

@markpeek
Copy link
Author

Thanks @TheTripleV for looking into the PR. I created a quick reproduction of the issue via this repo in case you wanted to look at it yourself.

@methane
Copy link

methane commented May 7, 2024

I want to remove all opengraph meta tag from ePub.
Would you check if app.builder.embedded: return in html_page_context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants